linux-mips
[Top] [All Lists]

Re: [RFC PATCH v2] au1000_eth: get ethernet address from platform_data

To: Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [RFC PATCH v2] au1000_eth: get ethernet address from platform_data
From: Florian Fainelli <florian@openwrt.org>
Date: Tue, 20 Jul 2010 13:24:20 +0200
Cc: Manuel Lauss <manuel.lauss@googlemail.com>, "Linux-MIPS" <linux-mips@linux-mips.org>, Wolfgang Grandegger <wg@denx.de>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:organization:to :subject:date:user-agent:cc:references:in-reply-to:mime-version :content-type:content-transfer-encoding:message-id; bh=aHSVOHcdCgxsrqC1/pdLuQlnoiBFuVs7qJffncwFHBc=; b=w0QPn6vWU33JVGtmJy1BAcue5vpzBe8eACSXnfNxDBcUDxlMapDio7m3FZRhsNs8dg l/+zpSzmnycvYSZvo3boQdFBfSo4+a7S/h4bouLYWaJChjLQbS7ZVw90vq10vX0CRCQj fKRRQB2GteLBgKTVVGU0rzyOIu3fiOP8ORBbs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; b=fHeq+fgyzSaQKNm2rReJxs5nWnFrVr3gGwLPlrcyjaO7KGCHKBpWefVom6h1ld05tG HsEFKm1QTHT+jJ7XbSHjXMtFskrxVnXTFTphvxiF/GNAKWe1JB9z1mwbHiG6Ee/S1YGb nz2Xqdygrfd0AbS6nSIVTZmjdsGHd5aoR1GA4=
In-reply-to: <4C45762E.70909@grandegger.com>
Organization: OpenWrt
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1279544125-28104-1-git-send-email-manuel.lauss@googlemail.com> <4C45762E.70909@grandegger.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.13.2 (Linux/2.6.32.15+drm33.5; KDE/4.4.2; x86_64; ; )
Hi Wolfgang, Manuel,

On Tuesday 20 July 2010 12:10:54 Wolfgang Grandegger wrote:
> Hi Manuel,
> 
> On 07/19/2010 02:55 PM, Manuel Lauss wrote:
> > Modify au1000_eth to receive an ethernet address from platform data,
> > or choose a random one.
> > 
> > The default address is usually provided by the firmware; modify
> > platform device registration to use it if the board code has not
> > already overridden it.
> > 
> > Cc: Wolfgang Grandegger <wg@denx.de>
> > Cc: Florian Fainelli <florian@openwrt.org>
> > Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> > ---
> > v2: diffed against linus-git, on top of Wolfgang's patch
> > 
> >     "mips/alchemy: define eth platform devices in the correct order"
> >     This one should actually apply cleanly.
> > 
> > IMHO a device driver should not call firmware-specific functions
> > (be it MIPS-style prom_get_*(), OF properties or whatever) to
> > get missing information.  Instead this should be done by the
> > platform code which sets up the device.  This patch does just that.
> > 
> > Compile-tested only.  Florian, Wolfgang: could you please give this
> > a try on your boards?  If it works and you agree to it, I'll
> > resubmit it also to linux-netdev.  Thank you! (I don't have
> > accessible au1000-eth hardware).
> 
> I gave the patch a try. The kernel builds and runs fine. The eth's are
> realized in the correct order and do work properly. Feel free to add my
> "Tested-by: Wolfgang Grandegger <wg@denx.de>".

I will not be able to test it soon, so go ahead for merging it. Thanks!
--
Florian

<Prev in Thread] Current Thread [Next in Thread>