linux-mips
[Top] [All Lists]

Re: [PATCH] mips/alchemy: define eth platform devices in the correct

To: Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH] mips/alchemy: define eth platform devices in the correct order
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Sat, 17 Jul 2010 19:01:14 +0200
Cc: linux-mips@linux-mips.org, Wolfgang Grandegger <wg@denx.de>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Eq6uCSry74u4+0f5zd9nSbUac1FMA27ksMpPPNr/FDg=; b=PW/C1xv6fqgy5QeBL5B8fNXYGFb79SF64h4/OFFo1Ee0r0NMYZ8wHd6W47fmksQoAl D+ylnkAOPElQFehs6pZJ3jhLwNGGZaHnKSybJZ6uvK33LoYXtZtCY5ouf1ZrmaWZAHye hba/prgW33S6V9eXR6LNoze+K7A5RB4jV3DX4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=MtvUgG5aOZos5oby6l5CKV7hUTG6zNEBdjVMWYSi8m1Qtb0Vsp1j1YZDgF/wzEUbt2 lyBE1KrpHGImqI6gTYpCCvJ7gA+ZrhDGAFmqeQORADj7UZie99I8cX2GeMHLZmbHfqaX 00Yp9eYAlGAqsa6COEcZz4aRfEtgmLtasuyJY=
In-reply-to: <1279377528-3190-1-git-send-email-wg@grandegger.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1279377528-3190-1-git-send-email-wg@grandegger.com>
Sender: linux-mips-bounce@linux-mips.org
Servus Wolfgang,

On Sat, Jul 17, 2010 at 4:38 PM, Wolfgang Grandegger <wg@grandegger.com> wrote:
> From: Wolfgang Grandegger <wg@denx.de>
>
> Currently, the eth devices are probed in the inverse order, first
> au1xxx_eth1_device and then au1xxx_eth0_device. On the GPR board,
> this makes trouble:
>
>  # ifconfig|grep HWaddr
>  eth0      Link encap:Ethernet  HWaddr 00:50:C2:0C:30:01
>  eth1      Link encap:Ethernet  HWaddr 66:22:01:80:38:10
>
> A bogous ethernet hwaddr is assigned to the first device and
> au1xxx_eth0_device is mapped to eth1, which even does not work
> properly. With this patch, the problems are gone:
>
>  # ifconfig|grep HWaddr
>  eth0      Link encap:Ethernet  HWaddr 66:22:11:32:38:10
>  eth1      Link encap:Ethernet  HWaddr 66:22:11:32:38:11

Interesting.  I don't disagree with the patch; what do you think about
passing MAC address via platform_data?   I don't particularly like
how the driver is trying to get a MAC address using the prom interface.

I'll try to cook something up.

Manuel

<Prev in Thread] Current Thread [Next in Thread>