| To: | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Subject: | Re: [PATCH v6] MMC: Add JZ4740 mmc driver |
| From: | Lars-Peter Clausen <lars@metafoo.de> |
| Date: | Thu, 15 Jul 2010 23:37:49 +0200 |
| Cc: | Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Matt Fleming <matt@console-pimps.org>, linux-mmc@vger.kernel.org |
| In-reply-to: | <20100715141653.1c0b6a8d.akpm@linux-foundation.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1278973245-25451-1-git-send-email-lars@metafoo.de> <1279227964-17801-1-git-send-email-lars@metafoo.de> <20100715141653.1c0b6a8d.akpm@linux-foundation.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla-Thunderbird 2.0.0.24 (X11/20100329) |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Andrew Morton wrote: > On Thu, 15 Jul 2010 23:06:04 +0200 > Lars-Peter Clausen <lars@metafoo.de> wrote: > >> This patch adds support for the mmc controller on JZ4740 SoCs. >> >> >> ... >> >> + if (gpio_is_valid(host->pdata->gpio_power)) >> + gpio_set_value(host->pdata->gpio_power, >> + !host->pdata->power_active_low); >> >> ... >> > > Should this driver have a `depends on GPIOLIB' in Kconfig? > The driver depends on MACH_JZ4740 which selects ARCH_REQUIRE_GPIOLIB, so there already is an implicit depends on GPIOLIB. - - Lars -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEUEARECAAYFAkw/f60ACgkQBX4mSR26RiNexQCfUXt0cqiMqEf17k+z+q6XVwRO ImEAmPKxeyX9ANVasUNL60f51GxKofg= =3NrE -----END PGP SIGNATURE----- |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v6] MMC: Add JZ4740 mmc driver, Andrew Morton |
|---|---|
| Next by Date: | [PATCH v3] MIPS: Add base support for Ingenic JZ4740 System-on-a-Chip, Lars-Peter Clausen |
| Previous by Thread: | Re: [PATCH v6] MMC: Add JZ4740 mmc driver, Andrew Morton |
| Next by Thread: | [PATCH] mips/alchemy: add basic support for the GPR board, Wolfgang Grandegger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |