linux-mips
[Top] [All Lists]

Re: [PATCH v2] mips/alchemy: add basic support for the GPR board

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH v2] mips/alchemy: add basic support for the GPR board
From: Wolfgang Grandegger <wg@grandegger.com>
Date: Wed, 14 Jul 2010 21:26:10 +0200
Cc: linux-mips@linux-mips.org, Wolfgang Grandegger <wg@denx.de>
In-reply-to: <AANLkTilwt8Eh9on0tjXecINx28ix1Bky8GiS-E4QdyIJ@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1279115243-11586-1-git-send-email-wg@grandegger.com> <AANLkTilwt8Eh9on0tjXecINx28ix1Bky8GiS-E4QdyIJ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4
On 07/14/2010 04:51 PM, Manuel Lauss wrote:
> On Wed, Jul 14, 2010 at 3:47 PM, Wolfgang Grandegger <wg@grandegger.com> 
> wrote:
>> diff --git a/arch/mips/alchemy/gpr/board_setup.c 
>> b/arch/mips/alchemy/gpr/board_setup.c
>> new file mode 100644
>> index 0000000..4e68d76
>> --- /dev/null
>> +++ b/arch/mips/alchemy/gpr/board_setup.c
> 
>> +static int __init gpr_init_irq(void)
>> +{
>> +       return 0;
>> +}
>> +arch_initcall(gpr_init_irq);
> 
> Seems superfluous.  Do you intend to add something here in the future?

Well, as PCMCIA is not supported on that board, it's actually not
needed. I will remove and it for v3.

Wolfgang.


<Prev in Thread] Current Thread [Next in Thread>