linux-mips
[Top] [All Lists]

Re: [PATCH v2] mips/alchemy: add basic support for the GPR board

To: Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH v2] mips/alchemy: add basic support for the GPR board
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Wed, 14 Jul 2010 16:51:18 +0200
Cc: linux-mips@linux-mips.org, Wolfgang Grandegger <wg@denx.de>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=pu+dsbSQ5v0oxZT9ATrYOwSHfziavA9IPn0ecEoRYzE=; b=CvVnKnb77YMmDy7zFqOfxD7FDfEioSbojzONmnxPWGmWAiwdToEiAA4jFm/3dbeywC 5FafCmL9/ldMkpmUxGQs/ahP76/9sIUGmu9tDvSfzpJNPBFiIFpqSxUOXkd6fVBMkQRf Aa6jxwizGEY4F0+9l7Uuxnhu99Wj1QJXFFGDU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=JAHR7qm/rxvybzhzh39YlIxEBOccaE7Y59IPs6GzhyV4ahFVRhd5K4YJlvlC8K7lO5 8Y63ljcXIKCKsiZXfhPYTCI7ENOBNY2lQlLTf8AZLt6P/Pz+JByDzwHssdLFglY7Aajp El0Nw+Yxvsrdxc6D0krWxsR7YrQEH15i8XyGs=
In-reply-to: <1279115243-11586-1-git-send-email-wg@grandegger.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1279115243-11586-1-git-send-email-wg@grandegger.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Jul 14, 2010 at 3:47 PM, Wolfgang Grandegger <wg@grandegger.com> wrote:
> diff --git a/arch/mips/alchemy/gpr/board_setup.c 
> b/arch/mips/alchemy/gpr/board_setup.c
> new file mode 100644
> index 0000000..4e68d76
> --- /dev/null
> +++ b/arch/mips/alchemy/gpr/board_setup.c

> +static int __init gpr_init_irq(void)
> +{
> +       return 0;
> +}
> +arch_initcall(gpr_init_irq);

Seems superfluous.  Do you intend to add something here in the future?

Otherwise looks ok to me.

Thank you!
        Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>