linux-mips
[Top] [All Lists]

Re: [PATCH v4] MMC: Add JZ4740 mmc driver

To: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v4] MMC: Add JZ4740 mmc driver
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Mon, 12 Jul 2010 14:41:39 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Matt Fleming <matt@console-pimps.org>, linux-mmc@vger.kernel.org
In-reply-to: <1278970413-21617-1-git-send-email-lars@metafoo.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1277688041-23522-1-git-send-email-lars@metafoo.de> <1278970413-21617-1-git-send-email-lars@metafoo.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.19 (X11/20081227)
Lars-Peter Clausen wrote:
> This patch adds support for the mmc controller on JZ4740 SoCs.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Acked-by: Matt Fleming <matt@console-pimps.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Matt Fleming <matt@console-pimps.org>
> Cc: linux-mmc@vger.kernel.org
> 
> ---
>  arch/mips/include/asm/mach-jz4740/jz4740_mmc.h |   15 +
>  drivers/mmc/host/Kconfig                       |    8 +
>  drivers/mmc/host/Makefile                      |    1 +
>  drivers/mmc/host/jz4740_mmc.c                  | 1024 
> ++++++++++++++++++++++++
>  4 files changed, 1048 insertions(+), 0 deletions(-)
>  create mode 100644 arch/mips/include/asm/mach-jz4740/jz4740_mmc.h
>  create mode 100644 drivers/mmc/host/jz4740_mmc.c
> 
> diff --git a/arch/mips/include/asm/mach-jz4740/jz4740_mmc.h 
> b/arch/mips/include/asm/mach-jz4740/jz4740_mmc.h
> new file mode 100644
> index 0000000..8543f43
> --- /dev/null
> +++ b/arch/mips/include/asm/mach-jz4740/jz4740_mmc.h
> @@ -0,0 +1,15 @@
> +#ifndef __LINUX_MMC_JZ4740_MMC
> +#define __LINUX_MMC_JZ4740_MMC
> +
> +struct jz4740_mmc_platform_data {
> +     int gpio_power;
> +     int gpio_card_detect;
> +     int gpio_read_only;
> +     unsigned card_detect_active_low:1;
> +     unsigned read_only_active_low:1;
> +     unsigned power_active_low:1;
> +
> +     unsigned data_1bit:1;
> +};
> +
> +#endif
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f06d06e..546fc49 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -81,6 +81,14 @@ config MMC_RICOH_MMC
>  
>         If unsure, say Y.
>  
> +config MMC_JZ4740
> +     tristate "JZ4740 SD/Multimedia Card Interface support"
> +     depends on MACH_JZ4740

What tree has the kconfig symbol MACH_JZ4740 in it?
I can't seem to find it...

Should the depends also say anything about GPIO?
I only ask because the header file above mentions gpio.

> +     help
> +       This selects the Ingenic Z4740 SD/Multimedia card Interface.
> +       If you have an ngenic platform with a Multimedia Card slot,

                         Ingenic ?

> +       say Y or M here.
> +
>  config MMC_SDHCI_OF
>       tristate "SDHCI support on OpenFirmware platforms"
>       depends on MMC_SDHCI && PPC_OF


<Prev in Thread] Current Thread [Next in Thread>