linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: MTX-1: cleanup and comments

To: Bruno Randolf <randolf.bruno@googlemail.com>
Subject: Re: [PATCH 2/2] MIPS: MTX-1: cleanup and comments
From: Florian Fainelli <florian@openwrt.org>
Date: Sun, 11 Jul 2010 19:11:01 +0200
Cc: linux-mips@linux-mips.org, manuel.lauss@googlemail.com, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:reply-to:to :subject:date:user-agent:cc:references:in-reply-to:mime-version :content-type:content-transfer-encoding:message-id; bh=Wcdtoqa6H9UmmcGKKgbPUhyDEFAcMAZEiRX7AHEFshs=; b=qnFXwx7KSqP/u2oMSlr9baof/o9Te7xZEKsFKfbCU/DJlFKP9G7oxtEBUc+joMZrsX M5eGtn+Y+7Rv/2N9qKvjUty9W0NyFmsyCuGelBpVa76wrjYAUWhzakuYgHazbk6n1uDp o3yleFXLPjC9CTbgxlXxm4DNPq/cx9xcS917c=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:reply-to:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; b=o8qNe566WA5pKXeVhDAtXNigLahypb5iz3O3FP2ubfM94W+AXDTiBgv9DpJFJ2jJlS ijZNFda3whvlpEaRRylm1g8vy5Zdhv0t5xpltsU9ORPXw+HfbV+0aKoVng1MlxUXkxpS nfCHpfIe1idzWNeOA9PvHd7gZHthXKFiS0tzc=
In-reply-to: <20100711154038.29863.23111.stgit@void>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20100711154028.29863.74414.stgit@void> <20100711154038.29863.23111.stgit@void>
Reply-to: Florian Fainelli <florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.13.3 (Linux/2.6.34-1-amd64; KDE/4.4.4; x86_64; ; )
Le Sunday 11 July 2010 17:40:38, Bruno Randolf a écrit :
> Add some comments about mtx1_pci_idsel() and remove a dead block of old
> code.
> 
> Signed-off-by: Bruno Randolf <br1@einfach.org>

Acked-by: Florian Fainelli <florian@openwrt.org>

> ---
>  arch/mips/alchemy/mtx-1/board_setup.c |   12 ++++--------
>  1 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/mips/alchemy/mtx-1/board_setup.c
> b/arch/mips/alchemy/mtx-1/board_setup.c index 52d883d..3cf2fa2 100644
> --- a/arch/mips/alchemy/mtx-1/board_setup.c
> +++ b/arch/mips/alchemy/mtx-1/board_setup.c
> @@ -105,14 +105,10 @@ void __init board_setup(void)
>  int
>  mtx1_pci_idsel(unsigned int devsel, int assert)
>  {
> -#define MTX_IDSEL_ONLY_0_AND_3 0
> -#if MTX_IDSEL_ONLY_0_AND_3
> -     if (devsel != 0 && devsel != 3) {
> -             printk(KERN_ERR "*** not 0 or 3\n");
> -             return 0;
> -     }
> -#endif
> -
> +     /* This function is only necessary to support a proprietary Cardbus
> +      * adapter on the mtx-1 "singleboard" variant. It triggers a custom
> +      * logic chip connected to EXT_IO3 (GPIO1) to suppress IDSEL signals.
> +      */
>       if (assert && devsel != 0)
>               /* Suppress signal to Cardbus */
>               alchemy_gpio_set_value(1, 0);   /* set EXT_IO3 OFF */

<Prev in Thread] Current Thread [Next in Thread>