| To: | linux-mips@linux-mips.org, manuel.lauss@googlemail.com, ralf@linux-mips.org |
|---|---|
| Subject: | [PATCH 2/2] MIPS: MTX-1: cleanup and comments |
| From: | Bruno Randolf <randolf.bruno@googlemail.com> |
| Date: | Mon, 12 Jul 2010 00:40:38 +0900 |
| Cc: | florian@openwrt.org |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:subject:to:from:cc:date :message-id:in-reply-to:references:user-agent:mime-version :content-type:content-transfer-encoding; bh=63HqvPUXp11T8uBoZm8EFxXdUXoNXSIXnbTNUHyLuKw=; b=mKJgNMw7WwUVakE6orD63Veallnd9AHcRbIreD+lVkOEkhATa42Vj2MXYS56YyuHOn NeK2CXMBFqU5pAhLFxF1EFBDo69PsFQViqa+kgQ1urfsuYAZGkDTv9gPIFUaR5PmWk4j 9LHVlDu9nn+ypHDxhjLy93IvrpTgM2fvTS1+Y= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; b=lYEQ7onxft/sXo9kx4SIdLCvulFyNXdJ1kgzfnxTaBJ+neBRhvv01Tcp0RbcYjP/UX YEpfvTVuhXjJwLFaB4ts/r7If956xgZryrZZunRhTnCWz0jHzTW1eBbZOFjQ5UDsJLQi Sr24og7lbJSHfL7LkOCkANPOfDEQgFB6fVbG0= |
| In-reply-to: | <20100711154028.29863.74414.stgit@void> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20100711154028.29863.74414.stgit@void> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | StGit/0.15 |
Add some comments about mtx1_pci_idsel() and remove a dead block of old code.
Signed-off-by: Bruno Randolf <br1@einfach.org>
---
arch/mips/alchemy/mtx-1/board_setup.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/arch/mips/alchemy/mtx-1/board_setup.c
b/arch/mips/alchemy/mtx-1/board_setup.c
index 52d883d..3cf2fa2 100644
--- a/arch/mips/alchemy/mtx-1/board_setup.c
+++ b/arch/mips/alchemy/mtx-1/board_setup.c
@@ -105,14 +105,10 @@ void __init board_setup(void)
int
mtx1_pci_idsel(unsigned int devsel, int assert)
{
-#define MTX_IDSEL_ONLY_0_AND_3 0
-#if MTX_IDSEL_ONLY_0_AND_3
- if (devsel != 0 && devsel != 3) {
- printk(KERN_ERR "*** not 0 or 3\n");
- return 0;
- }
-#endif
-
+ /* This function is only necessary to support a proprietary Cardbus
+ * adapter on the mtx-1 "singleboard" variant. It triggers a custom
+ * logic chip connected to EXT_IO3 (GPIO1) to suppress IDSEL signals.
+ */
if (assert && devsel != 0)
/* Suppress signal to Cardbus */
alchemy_gpio_set_value(1, 0); /* set EXT_IO3 OFF */
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/2] MIPS: MTX-1: fix PCI on the MeshCube and related boards, Bruno Randolf |
|---|---|
| Next by Date: | Re: [PATCH 1/2] MIPS: MTX-1: fix PCI on the MeshCube and related boards, Florian Fainelli |
| Previous by Thread: | [PATCH 1/2] MIPS: MTX-1: fix PCI on the MeshCube and related boards, Bruno Randolf |
| Next by Thread: | Re: [PATCH 2/2] MIPS: MTX-1: cleanup and comments, Florian Fainelli |
| Indexes: | [Date] [Thread] [Top] [All Lists] |