linux-mips
[Top] [All Lists]

Re: [PATCH v2 17/26] MTD: Nand: Add JZ4740 NAND driver

To: dedekind1@gmail.com
Subject: Re: [PATCH v2 17/26] MTD: Nand: Add JZ4740 NAND driver
From: Lars-Peter Clausen <lars@metafoo.de>
Date: Thu, 08 Jul 2010 15:20:04 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, David Woodhouse <dwmw2@infradead.org>, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
In-reply-to: <1278569214.12733.38.camel@localhost>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1276924111-11158-1-git-send-email-lars@metafoo.de> <1276924111-11158-18-git-send-email-lars@metafoo.de> <1278569214.12733.38.camel@localhost>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla-Thunderbird 2.0.0.24 (X11/20100329)
Artem Bityutskiy wrote:
> On Sat, 2010-06-19 at 07:08 +0200, Lars-Peter Clausen wrote:
>> diff --git a/include/linux/mtd/jz4740_nand.h 
>> b/include/linux/mtd/jz4740_nand.h
>> new file mode 100644
>> index 0000000..379f9b6
>> --- /dev/null
>> +++ b/include/linux/mtd/jz4740_nand.h
>> @@ -0,0 +1,34 @@
>> +/*
>> + *  Copyright (C) 2009-2010, Lars-Peter Clausen <lars@metafoo.de>
>> + *  JZ4740 SoC NAND controller driver
>> + *
>> + *  This program is free software; you can redistribute      it and/or 
>> modify it
>> + *  under  the terms of      the GNU General  Public License as published 
>> by the
>> + *  Free Software Foundation;  either version 2 of the      License, or (at 
>> your
>> + *  option) any later version.
>> + *
>> + *  You should have received a copy of the  GNU General Public License along
>> + *  with this program; if not, write  to the Free Software Foundation, Inc.,
>> + *  675 Mass Ave, Cambridge, MA 02139, USA.
>> + *
>> + */
>> +
>> +#ifndef __JZ_NAND_H__
>> +#define __JZ_NAND_H__
>> +
>> +#include <linux/mtd/nand.h>
>> +#include <linux/mtd/partitions.h>
>> +
>> +struct jz_nand_platform_data {
>> +    int                     num_partitions;
>> +    struct mtd_partition    *partitions;
>> +
>> +    struct nand_ecclayout   *ecc_layout;
>> +
>> +    unsigned int busy_gpio;
>> +
>> +    void (*ident_callback)(struct platform_device *, struct nand_chip *,
>> +                            struct mtd_partition **, int *num_partitions);
>> +};
>> +
>> +#endif
> 
> Do you really have to add your platform data strucutre to
> "inlculde/mtd" ? That is quite global namespace, and ideally only things
> like user-space interface and "public" interface of the MTD subsystem
> should live there.
> 
> Can you keep this somewhere in mips architecture directory?

Hi

Hm, ok, I see. I'll move it to arch/mips/include/asm/mach-jz4740/ then.
But I guess I should move the headers for all the other jz4740 driver to the 
same
directory as well.

On the other hand I'm wondering where on would put headers for non platform 
specific
drivers?

- Lars

<Prev in Thread] Current Thread [Next in Thread>