linux-mips
[Top] [All Lists]

Re: [PATCH v4] alsa: ASoC: Add JZ4740 codec driver

To: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v4] alsa: ASoC: Add JZ4740 codec driver
From: Liam Girdwood <lrg@slimlogic.co.uk>
Date: Tue, 22 Jun 2010 11:12:19 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Mark Brown <broonie@opensource.wolfsonmicro.com>, alsa-devel@alsa-project.org
In-reply-to: <1277160391-14737-1-git-send-email-lars@metafoo.de>
References: <1276958993-9012-1-git-send-email-lars@metafoo.de> <1277160391-14737-1-git-send-email-lars@metafoo.de>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2010-06-22 at 00:46 +0200, Lars-Peter Clausen wrote:
> This patch adds support for the JZ4740 internal codec.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: alsa-devel@alsa-project.org
> 
> ---
> Changes since v1
> - Put Kconfig entry in alphabetic order
> - Drop codec_set_fmt since the codec supports only one format
> - Rename "Capture Volume" control to "Master Capture Volume"
> - Drop unnecessary format checks
> - Add suspend/resume
> - Cleanup jz4740_codec_set_bias_level
> 
> Changes since v2
> - Drop codec prefix from the filename. Note that I keeped it for the object
>   name, because otherwise when build as a module it will clash with the ASoC
>   JZ4740 platform support.
> 
> Changes since v3
> - Hook up suspend/resume callbacks to the codec instead of the platform device

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk


<Prev in Thread] Current Thread [Next in Thread>