linux-mips
[Top] [All Lists]

Re: [PATCH v3] alsa: ASoC: Add JZ4740 codec driver

To: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v3] alsa: ASoC: Add JZ4740 codec driver
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
Date: Sun, 20 Jun 2010 14:11:53 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>, alsa-devel@alsa-project.org
In-reply-to: <1276958993-9012-1-git-send-email-lars@metafoo.de>
References: <1276924111-11158-21-git-send-email-lars@metafoo.de> <1276958993-9012-1-git-send-email-lars@metafoo.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-06-14)
On Sat, Jun 19, 2010 at 04:49:53PM +0200, Lars-Peter Clausen wrote:

This looks good, just one thing:

> +#ifdef CONFIG_PM_SLEEP
> +
> +static int jz4740_codec_suspend(struct device *dev)
> +{
> +     struct jz4740_codec *jz4740_codec = dev_get_drvdata(dev);
> +     return jz4740_codec_set_bias_level(&jz4740_codec->codec,
> +             SND_SOC_BIAS_OFF);
> +}

You've got these set up on the CODEC platform device rather than the
ASoC CODEC.  This means that the suspend and resume will happen out of
sequence with the rest of the ASoC suspend and resume which could result
in poor performance or bugs if the device is suspended while the core
still thinks it's active.  For example, ASoC will use DAPM to shut down
the CODEC and it's possible that the CODEC could be suspended (and
generate an audible noise) while an external amplifier is still powered,
worsening the problem.

<Prev in Thread] Current Thread [Next in Thread>