linux-mips
[Top] [All Lists]

Re: [lm-sensors] [PATCH v4] hwmon: Add JZ4740 ADC driver

To: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [lm-sensors] [PATCH v4] hwmon: Add JZ4740 ADC driver
From: Jean Delvare <khali@linux-fr.org>
Date: Sun, 20 Jun 2010 08:32:21 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Lars-Peter Clausen <lars@metafoo.de>, linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
In-reply-to: <1276975978-25778-1-git-send-email-lars@metafoo.de>
References: <1276958820-8862-1-git-send-email-lars@metafoo.de> <1276975978-25778-1-git-send-email-lars@metafoo.de>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 19 Jun 2010 21:32:58 +0200, Lars-Peter Clausen wrote:
> This patch adds support for reading the ADCIN pin of ADC unit on JZ4740 SoCs.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: lm-sensors@lm-sensors.org
> 
> --
> Changes since v1
> - Move ADC core access synchronizing from the HWMON driver to a MFD driver. 
> The
>   ADC driver now only reads the adcin value.
> 
> Changes since v2
>   - Add name sysfs attribute
>   - Report adcin in value in millivolts
> 
> Changes since v3
>   - Fix Kconfig entry
>   - Add include to completion.h
>   - Break overlong lines
>   - Use DEVICE_ATTR instead of SENSOR_DEVICE_ATTR for the adcin sys file.
> ---
>  drivers/hwmon/Kconfig        |   10 ++
>  drivers/hwmon/Makefile       |    1 +
>  drivers/hwmon/jz4740-hwmon.c |  226 
> ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 237 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/hwmon/jz4740-hwmon.c
> (...)

Acked-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare

<Prev in Thread] Current Thread [Next in Thread>