linux-mips
[Top] [All Lists]

Re: MIPS: return after handling coprocessor 2 exception

To: "Gleb O. Raiko" <raiko@niisi.msk.ru>
Subject: Re: MIPS: return after handling coprocessor 2 exception
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 18 Jun 2010 13:14:03 +0100
Cc: David Daney <ddaney@caviumnetworks.com>, Jesper Nilsson <jesper@jni.nu>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <4C1B4C0A.9070506@niisi.msk.ru>
References: <20100617132554.GB24162@jni.nu> <4C1A57AE.9080706@caviumnetworks.com> <4C1B263E.7070906@niisi.msk.ru> <20100618100053.GA4466@linux-mips.org> <4C1B4C0A.9070506@niisi.msk.ru>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Fri, Jun 18, 2010 at 02:35:54PM +0400, Gleb O. Raiko wrote:

> >static int default_cu2_call(struct notifier_block *nfb, unsigned long action,
> >         void *data)
> >{
> >     ...
> >
> >     return NOTIFY_OK | NOTIFY_STOP;
> NOTIFY_STOP implies NOTIFY_OK, so
>       return NOTIFY_STOP;
> shall be enough.

Correct - I was thinking NOTIFY_STOP_MASK.

> >}
> 
> >The notifier list could also be used for example by perf
> 
> Or octeon cop2 handler that just sends NOTIFY_BAD for getting the
> same behavior.

Bad karma to return an error for where none happened.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>