linux-mips
[Top] [All Lists]

Re: [PATCH 5/9] Removing dead CONFIG_BLK_DEV_IDE

To: Shane McDonald <mcdonald.shane@gmail.com>
Subject: Re: [PATCH 5/9] Removing dead CONFIG_BLK_DEV_IDE
From: Christoph Egger <siccegge@cs.fau.de>
Date: Wed, 16 Jun 2010 13:35:48 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, vamos@i4.informatik.uni-erlangen.de
In-reply-to: <AANLkTillx50SaxZU2cT9YSlS4uRF_ED5-wlG-JwfXfFT@mail.gmail.com>
References: <cover.1275925108.git.siccegge@cs.fau.de> <73e9e4bd7615488c9567f02f8962825386956365.1275925108.git.siccegge@cs.fau.de> <AANLkTillx50SaxZU2cT9YSlS4uRF_ED5-wlG-JwfXfFT@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jun 10, 2010 at 12:23:06PM -0600, Shane McDonald wrote:
>   I wonder if, instead of deleting the code, the constant should be
> changed from CONFIG_BLK_DEV_IDE to CONFIG_IDE.  The original
> patch that removed CONFIG_BLK_DEV_IDE seemed to make this change:
> http://kerneltrap.org/mailarchive/linux-kernel/2008/8/13/2929444
> 
> Shane

You're probably right, updated patch below

-------
From: Christoph Egger <siccegge@cs.fau.de>
Date: Mon, 7 Jun 2010 17:29:48 +0200
Subject: [PATCH 5/9] Removing dead CONFIG_BLK_DEV_IDE

CONFIG_BLK_DEV_IDE doesn't exist in Kconfig, therefore removing all
references for it from the source code.

Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
---
diff --git a/arch/mips/mti-malta/malta-setup.c
b/arch/mips/mti-malta/malta-setup.c
index b7f37d4..f6a5ea8 100644
--- a/arch/mips/mti-malta/malta-setup.c
+++ b/arch/mips/mti-malta/malta-setup.c
@@ -105,7 +105,7 @@ static void __init fd_activate(void)
 }
 #endif
 
-#ifdef CONFIG_BLK_DEV_IDE
+#ifdef CONFIG_IDE
 static void __init pci_clock_check(void)
 {
        unsigned int __iomem *jmpr_p =
@@ -207,7 +207,7 @@ void __init plat_mem_setup(void)
        if (mips_revision_sconid == MIPS_REVISION_SCON_BONITO)
                bonito_quirks_setup();
 
-#ifdef CONFIG_BLK_DEV_IDE
+#ifdef CONFIG_IDE
        pci_clock_check();
 #endif
 

<Prev in Thread] Current Thread [Next in Thread>