| To: | Wu Zhangjin <wuzhangjin@gmail.com> |
|---|---|
| Subject: | Re: [PATCH v4] MIPS: Clean up the calculation of VMLINUZ_LOAD_ADDRESS |
| From: | Sam Ravnborg <sam@ravnborg.org> |
| Date: | Wed, 2 Jun 2010 21:48:17 +0200 |
| Cc: | Ralf Baechle <ralf@linux-mips.org>, linux-mips <linux-mips@linux-mips.org>, Alexander Clouter <alex@digriz.org.uk>, Manuel Lauss <manuel.lauss@gmail.com> |
| In-reply-to: | <96f3b48ba7f749c4357760008cdae644aa55b92d.1275438520.git.wuzhangjin@gmail.com> |
| References: | <9890d1383c75ce6df44d357687a9c4e2d6ba4050.1275438553.git.wuzhangjin@gmail.com> <96f3b48ba7f749c4357760008cdae644aa55b92d.1275438520.git.wuzhangjin@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Wed, Jun 02, 2010 at 04:35:25PM +0800, Wu Zhangjin wrote: > We have calculated VMLINUZ_LOAD_ADDRESS in shell, which is indecipherable. > This > patch rewrites it in C. > > Changes: > > v3 -> v4: (feedback from Sam Ravnborg) > o Makefile: Follow the 80 characters' limit and Remove an un-needed objcopy. > o calc_vmlinuz_load_addr.c: Use a smaller alignment and Add more comments > > v2 -> v3: (feedback from Alexander Clouter) > o Drop the unneeded variable n > o Replace the last "unsigned long long" by uint64_t > > v1 -> v2: (feedback from Alexander Clouter) > o make it more portable > use EXIT_SUCCESS and EXIT_FAILURE as the return value, and use uint64_t > instead of "unsigned long long". > o add a missing return value > return EXIT_FAILURE if sscanf() not return 1 > > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC][PATCH 16/26] fbdev: Add JZ4740 framebuffer driver, Andrew Morton |
|---|---|
| Next by Date: | Re: [RFC][PATCH 16/26] fbdev: Add JZ4740 framebuffer driver, Lars-Peter Clausen |
| Previous by Thread: | [PATCH v4] MIPS: Clean up the calculation of VMLINUZ_LOAD_ADDRESS, Wu Zhangjin |
| Next by Thread: | Re: [PATCH v4] MIPS: Clean up the calculation of VMLINUZ_LOAD_ADDRESS, Alexander Clouter |
| Indexes: | [Date] [Thread] [Top] [All Lists] |