Re: [PATCH -queue] MIPS: Move Alchemy Makefile parts to their own Platform file.

[Manuel Lauss <manuel.lauss@googlemail.com>]

Hi Sam,
On Mon, May 31, 2010 at 11:18 PM, Sam Ravnborg <sam@ravnborg.org> wrote:

>> --- a/arch/mips/Kbuild.platforms
>> +++ b/arch/mips/Kbuild.platforms
>> @@ -1,6 +1,6 @@
>>  # All platforms listed in alphabetic order
>>
>> -platforms += ar7
>> +platforms += alchemy ar7
>
> One line per paltform is better.
> Then the risk for conflicts are less and merging in easier.
> Like this:
>
> platforms += ar7
> platforms += alchemy

Done,


>> diff --git a/arch/mips/alchemy/Platform b/arch/mips/alchemy/Platform
>> new file mode 100644
>> index 0000000..1994fdc
>> --- /dev/null
>> +++ b/arch/mips/alchemy/Platform
>> @@ -0,0 +1,103 @@
>> +#
>> +# Common Alchemy Au1x00 stuff
>> +#
>> +core-$(CONFIG_SOC_AU1X00)    += arch/mips/alchemy/common/
>
> The above is actually wrong - despite that it works.
> You are supposed to use:
>
> platform-$(CONFIG_SOC_AU1X00) += alchemy/common/
>
> Then arch/mips/Kbuild will pick it up.
> And then subdirs-ccflags-y := -Werror will also take effect.

Ah, interesting.  I shall look at the full commandline in the future.

I'll do a build of all alchemy boards and resend when there are
no breakages.

Thank you!
     Manuel Lauss