linux-mips
[Top] [All Lists]

Re: [PATCH -queue] MIPS: Move Alchemy Makefile parts to their own

To: Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH -queue] MIPS: Move Alchemy Makefile parts to their own Platform file.
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Tue, 1 Jun 2010 08:23:21 +0200
Cc: Linux-MIPS <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=pYnWup1x8h9RmxGpohV8/ahMYJyWhK1vzu09B9nMgEs=; b=lyxqWtC3HFfywp8rM+KZT0olzjeMfrXrWLsyNXtHDFac6d4m0gFRX2E4U3K2+6Qp2G LNTESU8tJM0MEo+HMtfs0me3KzktlJvHfJOkYvnDpDf2wel/vsT+l/vK0Tc2kUP1N7TG bsLjBeQso9VrAKU+3mcZvvXGfx4aEa+Avr8gU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=uPc1Th2R7ZUAGJpfw2Ruo25p3OOTprYh5X4QYAssiLanQMHckbQRLwtJGDOqu0ZPsO ZHOpJYySOKowfHYVUmtj55+m7Q1GUOSNrKwPGnn1fg7zHI8gRSp/VQzY/zj1vsQ0weRY oAa52JlIFGgad21fXAlN6Q4RtpR518Gi8qUWo=
In-reply-to: <20100531211842.GA795@merkur.ravnborg.org>
References: <1275332878-19762-1-git-send-email-manuel.lauss@googlemail.com> <20100531211842.GA795@merkur.ravnborg.org>
Sender: linux-mips-bounce@linux-mips.org
Hi Sam,
On Mon, May 31, 2010 at 11:18 PM, Sam Ravnborg <sam@ravnborg.org> wrote:

>> --- a/arch/mips/Kbuild.platforms
>> +++ b/arch/mips/Kbuild.platforms
>> @@ -1,6 +1,6 @@
>>  # All platforms listed in alphabetic order
>>
>> -platforms += ar7
>> +platforms += alchemy ar7
>
> One line per paltform is better.
> Then the risk for conflicts are less and merging in easier.
> Like this:
>
> platforms += ar7
> platforms += alchemy

Done,


>> diff --git a/arch/mips/alchemy/Platform b/arch/mips/alchemy/Platform
>> new file mode 100644
>> index 0000000..1994fdc
>> --- /dev/null
>> +++ b/arch/mips/alchemy/Platform
>> @@ -0,0 +1,103 @@
>> +#
>> +# Common Alchemy Au1x00 stuff
>> +#
>> +core-$(CONFIG_SOC_AU1X00)    += arch/mips/alchemy/common/
>
> The above is actually wrong - despite that it works.
> You are supposed to use:
>
> platform-$(CONFIG_SOC_AU1X00) += alchemy/common/
>
> Then arch/mips/Kbuild will pick it up.
> And then subdirs-ccflags-y := -Werror will also take effect.

Ah, interesting.  I shall look at the full commandline in the future.

I'll do a build of all alchemy boards and resend when there are
no breakages.

Thank you!
     Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH -queue] MIPS: Move Alchemy Makefile parts to their own Platform file., Manuel Lauss <=