linux-mips
[Top] [All Lists]

Re: [PATCH -queue] MIPS: Move Alchemy Makefile parts to their own

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH -queue] MIPS: Move Alchemy Makefile parts to their own Platform file.
From: Sam Ravnborg <sam@ravnborg.org>
Date: Mon, 31 May 2010 23:18:42 +0200
Cc: Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <1275332878-19762-1-git-send-email-manuel.lauss@googlemail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1275332878-19762-1-git-send-email-manuel.lauss@googlemail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
Hi Manuel.

A few comments below.

> 
> diff --git a/arch/mips/Kbuild.platforms b/arch/mips/Kbuild.platforms
> index 681b2d4..18eff23 100644
> --- a/arch/mips/Kbuild.platforms
> +++ b/arch/mips/Kbuild.platforms
> @@ -1,6 +1,6 @@
>  # All platforms listed in alphabetic order
>  
> -platforms += ar7
> +platforms += alchemy ar7

One line per paltform is better.
Then the risk for conflicts are less and merging in easier.
Like this:

platforms += ar7
platforms += alchemy

But this is a nitpick only.

> diff --git a/arch/mips/alchemy/Platform b/arch/mips/alchemy/Platform
> new file mode 100644
> index 0000000..1994fdc
> --- /dev/null
> +++ b/arch/mips/alchemy/Platform
> @@ -0,0 +1,103 @@
> +#
> +# Common Alchemy Au1x00 stuff
> +#
> +core-$(CONFIG_SOC_AU1X00)    += arch/mips/alchemy/common/

The above is actually wrong - despite that it works.
You are supposed to use:

platform-$(CONFIG_SOC_AU1X00) += alchemy/common/

Then arch/mips/Kbuild will pick it up.
And then subdirs-ccflags-y := -Werror will also take effect.

The reason why it works now is that the core-y assignment is
picked up by arch/mips/Makefile.

I could do something to avoid this but I hope this is not needed.

You use core-$(...) in many places that all needs fixing.

        Sam

<Prev in Thread] Current Thread [Next in Thread>