linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: Fix deferred console messages during CPU hotplug

To: Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH 2/2] MIPS: Fix deferred console messages during CPU hotplug
From: Paul Mundt <lethal@linux-sh.org>
Date: Mon, 31 May 2010 13:41:45 +0900
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <526fcbfa605500d9da9b04ac0f93ef2beddca6ed@localhost.localdomain>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1b31306f28573a4bee56f164b1f74962fced9bc5@localhost.localdomain> <526fcbfa605500d9da9b04ac0f93ef2beddca6ed@localhost.localdomain>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
On Sun, May 30, 2010 at 12:35:58AM -0700, Kevin Cernekee wrote:
> diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
> index 6cdca19..bf8923f 100644
> --- a/arch/mips/kernel/smp.c
> +++ b/arch/mips/kernel/smp.c
> @@ -219,6 +220,10 @@ int __cpuinit __cpu_up(unsigned int cpu)
>  
>       cpu_set(cpu, cpu_online_map);
>  
> +     /* Flush out any buffered log messages from the new CPU */
> +     if (try_acquire_console_sem() == 0)
> +             release_console_sem();
> +
>       return 0;
>  }
>  
Since this is entirely generic why not just have kernel/printk.c register
a hotcpu notifier and handle this in the CPU_ONLINE case?

<Prev in Thread] Current Thread [Next in Thread>