linux-mips
[Top] [All Lists]

Re: [PATCH v5 11/12] MIPS/Oprofile: use Perf-events framework as

To: David Daney <david.s.daney@gmail.com>
Subject: Re: [PATCH v5 11/12] MIPS/Oprofile: use Perf-events framework as backend
From: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Date: Sat, 29 May 2010 11:15:48 +0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, a.p.zijlstra@chello.nl, paulus@samba.org, mingo@elte.hu, acme@redhat.com, jamie.iles@picochip.com, will.deacon@arm.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=x/AgJHtQ6Ahy8pNsIRGizE1ZU2jwx5EfoxRqv0PCOJk=; b=dtHP3FusGUHb81FhzxMjkhpID5SAQuyAw8buVvhDAOIy++xh1QIfDL0vClUnO3EfcS xWxGhVr8UI17TJKhJQK23RcGqO5GykSIcnntY/r+EXPLp7eEt+Lqu0em1iajgeY/hILa CIGeo1vtqWfY4B1RbCNZgNEr8rlBdXQvWbFQk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=YH4ipC8y2oIuIZJBcCDeK5BgicYcZarWuTg0a2l0t6VR3ObiH6SeaiXs+YEeunNLm0 C53TfrMttc7FWK3gjsV6hK79Skti6iAE8rlUTplrNvbm0S5nozQEBY1DlvVdQReeOyvv +Nj89GJHbEKwmmdxw5n327jw2RN8Y00ot3l00=
In-reply-to: <4BFEFF3B.3080009@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1274965420-5091-1-git-send-email-dengcheng.zhu@gmail.com> <1274965420-5091-12-git-send-email-dengcheng.zhu@gmail.com> <4BFEFF3B.3080009@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
2010/5/28 David Daney <david.s.daney@gmail.com>:
> The mips perf events system should already know what type of cpu it is
> running on.
>
> Can we have all this processor specific perf/counter stuff live in one place
> and simplify all of this?
[DC]: Do you mean to move init_hw_perf_events() out into perf_event.c, and
to deal with mipsxx/loongson2/rm9000/more together? If yes, that's OK.


> Too many magic numbers.  Lets have symbolic names.
[DC]: OK.


Deng-Cheng

<Prev in Thread] Current Thread [Next in Thread>