| To: | Ralf Baechle <ralf@linux-mips.org> |
|---|---|
| Subject: | [PATCH 2/9] tracing: MIPS: mcount.S: cleanup the arguments of prepare_ftrace_return |
| From: | Wu Zhangjin <wuzhangjin@gmail.com> |
| Date: | Fri, 14 May 2010 19:08:27 +0800 |
| Cc: | linux-mips <linux-mips@linux-mips.org>, David Daney <david.s.daney@gmail.com>, Wu Zhangjin <wuzhangjin@gmail.com> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references:in-reply-to:references; bh=PwuS6KbKCUJqUpCTlLCwumX2NC+1vOXggMD35QuPH30=; b=HzTSCkrVOds48lI2FCvYRwnE6zvrLDiePKbV3gOjBfg3ou0rvXQo7bkqRYVwsx2NdK Bc2hjRqXAsIMTvdw0iT/TyM6BZqe8H4U5z91opt8o/IPrZvVN0VuAaHc4PH+eCuAGZ+4 lwNBThzSiNBOU7fVtV5VegsFppYPj8PeBvc+0= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=fKJ965bsIh+geCjCnROvimuUyfNES85hXRi9jF6sKH3RVhe2YXtQTmU8Vj0Fs8YRJA EQj6zETZxTr/U9xdcWTh0sj234cp5zu1DQYyH0OHBByX3CDopUlVZvyok68fnz04PShj 6ZGPTemYV+2O88JsN0OwGEIkFPd0ohfmB9Ex0= |
| In-reply-to: | <cover.1273834561.git.wuzhangjin@gmail.com> |
| In-reply-to: | <cover.1273834561.git.wuzhangjin@gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <cover.1273834561.git.wuzhangjin@gmail.com> |
| References: | <cover.1273834561.git.wuzhangjin@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
From: Wu Zhangjin <wuzhangjin@gmail.com>
The old arguments handling for prepare_ftrace_return is awlful, this
patch cleans it up.
Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
---
arch/mips/kernel/mcount.S | 36 ++++++++++++++++++++++--------------
1 files changed, 22 insertions(+), 14 deletions(-)
diff --git a/arch/mips/kernel/mcount.S b/arch/mips/kernel/mcount.S
index e256bf9..d4a00d2 100644
--- a/arch/mips/kernel/mcount.S
+++ b/arch/mips/kernel/mcount.S
@@ -132,28 +132,34 @@ ftrace_stub:
#ifdef CONFIG_FUNCTION_GRAPH_TRACER
NESTED(ftrace_graph_caller, PT_SIZE, ra)
-#ifdef CONFIG_DYNAMIC_FTRACE
- PTR_L a1, PT_R31(sp) /* load the original ra from the stack */
-#ifdef KBUILD_MCOUNT_RA_ADDRESS
- PTR_L t0, PT_R12(sp) /* load the original t0 from the stack */
-#endif
-#else
+#ifndef CONFIG_DYNAMIC_FTRACE
MCOUNT_SAVE_REGS
- move a1, ra /* arg2: next ip, selfaddr */
#endif
+ /* arg1: Get the location of the parent's return address */
#ifdef KBUILD_MCOUNT_RA_ADDRESS
- bnez t0, 1f /* non-leaf func: t0 saved the location of the
return address */
+#ifdef CONFIG_DYNAMIC_FTRACE
+ PTR_L a0, PT_R12(sp)
+#else
+ move a0, t0
+#endif
+ bnez a0, 1f /* non-leaf func: stored in t0 */
nop
- PTR_LA t0, PT_R1(sp) /* leaf func: get the location of at(old ra)
from our own stack */
-1: move a0, t0 /* arg1: the location of the return address */
+#endif
+ PTR_LA a0, PT_R1(sp) /* leaf func: the location in current stack */
+1:
+
+ /* arg2: Get self return address */
+#ifdef CONFIG_DYNAMIC_FTRACE
+ PTR_L a1, PT_R31(sp)
#else
- PTR_LA a0, PT_R1(sp) /* arg1: &AT -> a0 */
+ move a1, ra
#endif
- jal prepare_ftrace_return
+
+ /* arg3: Get frame pointer of current stack */
#ifdef CONFIG_FRAME_POINTER
- move a2, fp /* arg3: frame pointer */
-#else
+ move a2, fp
+#else /* ! CONFIG_FRAME_POINTER */
#ifdef CONFIG_64BIT
PTR_LA a2, PT_SIZE(sp)
#else
@@ -161,6 +167,8 @@ NESTED(ftrace_graph_caller, PT_SIZE, ra)
#endif
#endif
+ jal prepare_ftrace_return
+ nop
MCOUNT_RESTORE_REGS
RETURN_BACK
END(ftrace_graph_caller)
--
1.7.0.4
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 3/9] tracing: MIPS: mcount.S: cleanup of the comments, Wu Zhangjin |
|---|---|
| Next by Date: | [PATCH 4/9] tracing: MIPS: mcount.S: Fix the argument passing of the 32bit support with gcc 4.5, Wu Zhangjin |
| Previous by Thread: | Re: [PATCH 3/9] tracing: MIPS: mcount.S: cleanup of the comments, Ralf Baechle |
| Next by Thread: | Re: [PATCH 2/9] tracing: MIPS: mcount.S: cleanup the arguments of prepare_ftrace_return, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |