linux-mips
[Top] [All Lists]

Re: [RFC PATCH 1/2] The Device Tree Patch for MIPS

To: "Dezhong Diao (dediao)" <dediao@cisco.com>
Subject: Re: [RFC PATCH 1/2] The Device Tree Patch for MIPS
From: David Daney <ddaney@caviumnetworks.com>
Date: Thu, 13 May 2010 13:24:10 -0700
Cc: linux-mips@linux-mips.org, "David VomLehn (dvomlehn)" <dvomlehn@cisco.com>, "Tony Colclough (colclot)" <colclot@cisco.com>, Grant Likely <grant.likely@secretlab.ca>
In-reply-to: <7A9214B0DEB2074FBCA688B30B04400DC64936@XMB-RCD-208.cisco.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <7A9214B0DEB2074FBCA688B30B04400DC64936@XMB-RCD-208.cisco.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4
On 05/13/2010 11:50 AM, Dezhong Diao (dediao) wrote:
+/* which is compatible with the flattened device tree (FDT) */
+#define cmd_line arcs_cmdline

What is this #define floating in space?

The variable "cmd_line" is being used in generic code of device tree,
most of platforms (ARM, POWERPC
, etc) have its definition, but it isn't present in MIPS. Actually there
is a variable "arcs_cmdline" to be used as the same purpose in MIPS,
that is the reason "arcs_cmdline" is given a new name.


Really I was referring to the way the patch got horked up when you e-mailed it. It was very difficult to understand what the intent was.

I have no problem using #define, just make sure it doesn't have other garbage preceding the '#'

<Prev in Thread] Current Thread [Next in Thread>