Re: [RFC PATCH 1/2] The Device Tree Patch for MIPS

[David Daney <ddaney@caviumnetworks.com>]

On 05/13/2010 11:50 AM, Dezhong Diao (dediao) wrote:
> > > +/* which is compatible with the flattened device tree (FDT) */
> > > +#define cmd_line arcs_cmdline
> > What is this #define floating in space?
> The variable "cmd_line" is being used in generic code of device tree,
> most of platforms (ARM, POWERPC
> , etc) have its definition, but it isn't present in MIPS. Actually there
> is a variable "arcs_cmdline" to be used as the same purpose in MIPS,
> that is the reason "arcs_cmdline" is given a new name.
Really I was referring to the way the patch got horked up when you 
e-mailed it.  It was very difficult to understand what the intent was.
I have no problem using #define, just make sure it doesn't have other 
garbage preceding the '#'