|To:||"Dezhong Diao (dediao)" <firstname.lastname@example.org>|
|Subject:||Re: [RFC PATCH 1/2] The Device Tree Patch for MIPS|
|From:||David Daney <email@example.com>|
|Date:||Thu, 13 May 2010 13:24:10 -0700|
|Cc:||firstname.lastname@example.org, "David VomLehn (dvomlehn)" <email@example.com>, "Tony Colclough (colclot)" <firstname.lastname@example.org>, Grant Likely <email@example.com>|
|User-agent:||Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:220.127.116.11) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4|
On 05/13/2010 11:50 AM, Dezhong Diao (dediao) wrote:
+/* which is compatible with the flattened device tree (FDT) */ +#define cmd_line arcs_cmdlineWhat is this #define floating in space?The variable "cmd_line" is being used in generic code of device tree, most of platforms (ARM, POWERPC , etc) have its definition, but it isn't present in MIPS. Actually there is a variable "arcs_cmdline" to be used as the same purpose in MIPS, that is the reason "arcs_cmdline" is given a new name.
Really I was referring to the way the patch got horked up when you e-mailed it. It was very difficult to understand what the intent was.
I have no problem using #define, just make sure it doesn't have other garbage preceding the '#'
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||RE: [RFC PATCH 1/2] The Device Tree Patch for MIPS, Dezhong Diao (dediao)|
|Next by Date:||Re: [PATCH] Restore signalling NaN behaviour for abs.[sd], Atsushi Nemoto|
|Previous by Thread:||RE: [RFC PATCH 1/2] The Device Tree Patch for MIPS, Dezhong Diao (dediao)|
|Next by Thread:||RE: [RFC PATCH 2/2] The Device Tree Patch for MIPS, Dezhong Diao (dediao)|
|Indexes:||[Date] [Thread] [Top] [All Lists]|