linux-mips
[Top] [All Lists]

Re: About MIPS specific dma_mmap_coherent()

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: About MIPS specific dma_mmap_coherent()
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Wed, 12 May 2010 14:42:08 +0800
Cc: Takashi Iwai <tiwai@suse.de>, linux-mips <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=rY0KVxgZCoXOKE9L54+y3Kg6fmVr+QNl5vMnCMLVyPs=; b=BkipMLXw+vnYIwM5fbjAmVLcs2Zdw9rEDhb30f0bGEOBH9oDMFlFPyfj7lrQ02FQV+ ew/eRXnlvoVWtnTkp9KyZNOga/0gszN4nLqFGcdYyNoS8/MY9Mt+SLnE5RgvwFR/fbIr EXGzikmuWJuuywRa0dP64npnBwIovc6YXCkP4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=IZC4W75ucmX5wWPUd+Uyqb3i79d0AhO1SBjNQHITf4imwwY17WumWZ82V8GPAMumCu TJWBfq9h06hWeX9r5y7WhjjHw1NvJ/H11ony+ehzRNh3qHu4RwYErL/J0uDmmzGrjxHq fZ6fS/AIgSo/lqqxrGT352o6l1TEO6GyQp5GU=
In-reply-to: <20100511184844.GA7978@linux-mips.org>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1271134735.25797.35.camel@falcon> <s5hmxx7z4a7.wl%tiwai@suse.de> <1271218889.25872.27.camel@falcon> <s5hzl164kay.wl%tiwai@suse.de> <1271235619.25872.148.camel@falcon> <s5h633uxcje.wl%tiwai@suse.de> <20100511184844.GA7978@linux-mips.org>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
Hi, Ralf & Takashi

On Tue, 2010-05-11 at 19:48 +0100, Ralf Baechle wrote:
> On Wed, Apr 14, 2010 at 05:46:13PM +0200, Takashi Iwai wrote:
> 
> > But, I remember vaguely that calling pgprot_noncached()
> > unconditionally is dangerous.  It should be checked somehow, e.g. via
> > platform_device_is_coherent().  And, this found only in
> > dma-coherence.h, and adding it to pcm_native.c would become messy like
> > below...
> > 
> > So, it'd be really better to add dma_mmap_coherent(), indeed.
> 
> We agreed that this was only meant as a stop gap meassure.  As such I do
> agree with either of
> 
>   http://patchwork.linux-mips.org/patch/1117/
>   http://patchwork.linux-mips.org/patch/1118/
> 
> Wu has tested the 1117 patch so that might make it preferable especially
> for 2.6.34 if we should go for that.
> 

Just tested 1118, it works too ;)

Regards,
        Wu Zhangjin



<Prev in Thread] Current Thread [Next in Thread>