linux-mips
[Top] [All Lists]

[PATCH 2/2] AR7: prevent race between clock initialization and devices r

To: linux-mips@linux-mips.org
Subject: [PATCH 2/2] AR7: prevent race between clock initialization and devices registration
From: Florian Fainelli <florian@openwrt.org>
Date: Tue, 11 May 2010 11:20:14 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:date:subject :mime-version:x-uid:x-length:organization:to:cc:content-type :content-transfer-encoding:message-id; bh=YzJloH84CeA6gRxYyBaw/R30Nz7cVx7M7JFuAEJKznA=; b=p0mT7kr5pyDHTpXWHN3v14/fyLY3+oCF5BqCIu3+KR77QgGuNeEyRACTkhM3j4Ne82 uSyYmGzJuwuhDU3iOsHF6ez/VvM+Pk51WArgWynZ3LX2rY3fYifMtIqp4f6oiBEYvxw/ w5iQRKGCh2oMVdg98FjqfX+p3f9KOv+omv0zE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:date:subject:mime-version:x-uid:x-length:organization :to:cc:content-type:content-transfer-encoding:message-id; b=p/go7OT4tjCuNFhu1WI7sFk4hAqvKDKU7A9/E1ymncxJhiJhF/hBYHj0A4xr0nEdhU IxV52prIcrQ6B+SYyA6acJv64iabi/KDbSgEYimPT5ZqU6CsUL/7HRlk91HEB5aWRxsk WQgp/CCesHKbfs9BTvBu8k7FyglxAIG1CkWPI=
Organization: OpenWrt
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
ar7_regiser_devices needs ar7_clocks_init to have been called first, however
clock.o is currently linked later due to its order in the Makefile, therefore
ar7_clocks_init always gets called later than ar7_register_devices because both
have the same initcall level. Fix this by moving ar7_register_devices to the 
right
initcall level.

Reported-by: Michael J. Evans <mjevans1983@gmail.com>
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
index 1d4a466..566f2d7 100644
--- a/arch/mips/ar7/platform.c
+++ b/arch/mips/ar7/platform.c
@@ -647,4 +647,4 @@ static int __init ar7_register_devices(void)
 
        return 0;
 }
-arch_initcall(ar7_register_devices);
+device_initcall(ar7_register_devices);


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 2/2] AR7: prevent race between clock initialization and devices registration, Florian Fainelli <=