linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: nofpu and nodsp only affect CPU0

To: Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH] MIPS: nofpu and nodsp only affect CPU0
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 10 May 2010 21:41:49 +0100
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <20100510201959.GB28820@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <0b6db1ee1efbe0daa1320b59ab5093ba5af377b8@localhost.localdomain> <20100510201959.GB28820@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Mon, May 10, 2010 at 09:19:59PM +0100, Ralf Baechle wrote:

> > The "nofpu" and "nodsp" kernel command line options currently do not
> > affect CPUs that are brought online later in the boot process or
> > hotplugged at runtime.  It is desirable to apply the nofpu/nodsp options
> > to all CPUs in the system, so that surprising results are not seen when
> > a process migrates from one CPU to another.
> 
> I like this patch; this solution is also cleaner than iterating over the
> cpu data array.  However as it constitutes a change in established kernel
> behaviour I prefer to queue this patch for 2.6.35 rather than applying it
> immediately.

I've moved definitions of mips_fpu_disabled, fpu_disable, mips_dsp_disabled
and dsp_disable from setup.c to cpu-probe.c to allow mips_fpu_disabled and
mips_dsp_disabled to become static.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>