linux-mips
[Top] [All Lists]

Re: [PATCH v3 1/4] MIPS/Oprofile: extract PMU defines/helper fun

To: wuzhangjin@gmail.com
Subject: Re: [PATCH v3 1/4] MIPS/Oprofile: extract PMU defines/helper functions for sharing
From: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Date: Fri, 7 May 2010 11:12:35 +0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, a.p.zijlstra@chello.nl, paulus@samba.org, mingo@elte.hu, acme@redhat.com, jamie.iles@picochip.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=cjHROHrQAMq0Ym9a/eBHSbnHVtbJ6wHHwaekC4gYdqM=; b=bcCGTe7ppabznh/La7jU6U2dbVg0968HZIsYZBy5kwbeJ/EAMkIdWPJHh0D0tY/UE2 x7GWwzTyLcZ8wHnl+eyIDZtN66HoBQX3VI9jyBthP5Nixl2p5n34FTQA6E94yP7c+lqk Z1WF6yk1VVN72jfTwi/t/kP8ZInXEYCxCoIiQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=nWH2+hb+qyR5W7jxc/q1xTVuT1TXd3/mrTU8LKT9V7RkxpQAAWj4I1I50oXqNJUvQZ 9N7/fizpynlqzib1sxpImrJGzbhuqiqdSR9Y7+pT9TKcAUCuPUMejm+4S7UYjrx/5UMM HOeP4I9fRT0njp9WQIM5mSuLWlcqtf96rkgk4=
In-reply-to: <1273164852.23734.6.camel@localhost>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1273067734-4758-1-git-send-email-dengcheng.zhu@gmail.com> <1273067734-4758-2-git-send-email-dengcheng.zhu@gmail.com> <1273162909.23734.4.camel@localhost> <1273164852.23734.6.camel@localhost>
Sender: linux-mips-bounce@linux-mips.org
>> For we will use the save_perf_irq in the common function:
>> mipspmu_get_irq() of the next patch, so, we need to move the definition
>> of it out of the #if ... and put it before the #if:
>>
>> ...
>> +static int (*save_perf_irq)(void);
>>
>> #if defined(CONFIG_CPU_MIPS32)
>> ...
>
> oh, no, For Oprofile not use it, we can define it before
> mipspmu_get_irq() directly.
>

Thanks for your comments!

Just a correction: op_model_mipsxx.c will also use save_perf_irq. So
when taking your 2nd solution, we need to define another static
save_perf_irq in op_model_mipsxx.c.

<Prev in Thread] Current Thread [Next in Thread>