linux-mips
[Top] [All Lists]

Re: [PATCH v3 1/4] MIPS/Oprofile: extract PMU defines/helper functions f

To: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Subject: Re: [PATCH v3 1/4] MIPS/Oprofile: extract PMU defines/helper functions for sharing
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Fri, 07 May 2010 00:54:12 +0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, a.p.zijlstra@chello.nl, paulus@samba.org, mingo@elte.hu, acme@redhat.com, jamie.iles@picochip.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=3nx5AUqB8CiibyPqOU15BPwCbsDVJmHxsjGtA3EqHpw=; b=Uk8NhkgQHW7rfbm+c+BXiZpSPXJxMgT1GnH1ftXWHlQooMaw8OAi1eKthiRAQSic9+ T27S2jz8h93iNRS2znmKCShTuKQXowRFamLXi8Z/VhllxZ4Hg4hKhAVGdmv5PNYhiQXB 6LORsJQH2NgH5pY0sTN82h1HaHlGy/DXK5LTI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=fytqpxSFS909hmnziX1Dn/dEi8RB3+/rgaD9WkshrsCo9QkAmVmWrmJ+5EiGrRarFd E4shsWy2iLDnuRFZvAZ8Xbuvh4IqGuIycmzqfOhmQMt+1c8W6nEBRxX8OLGqf3AanwOn 1yJfHuIoOPmQrv4ltFWSBoR5GYNL+jwAl5Qfw=
In-reply-to: <1273162909.23734.4.camel@localhost>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1273067734-4758-1-git-send-email-dengcheng.zhu@gmail.com> <1273067734-4758-2-git-send-email-dengcheng.zhu@gmail.com> <1273162909.23734.4.camel@localhost>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Fri, 2010-05-07 at 00:21 +0800, Wu Zhangjin wrote:
> Hi,
> 
> On Wed, 2010-05-05 at 21:55 +0800, Deng-Cheng Zhu wrote:
> > Moving performance counter/control defines/helper functions into a single
> > header file, so that software using the MIPS PMU can share the code.
> > 
> > Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
> > ---
> >  arch/mips/include/asm/pmu.h             |  244 
> > +++++++++++++++++++++++++++++++
> >  arch/mips/oprofile/op_model_loongson2.c |   23 +---
> >  arch/mips/oprofile/op_model_mipsxx.c    |  164 +---------------------
> >  arch/mips/oprofile/op_model_rm9000.c    |   16 +--
> >  4 files changed, 247 insertions(+), 200 deletions(-)
> >  create mode 100644 arch/mips/include/asm/pmu.h
> > 
> > diff --git a/arch/mips/include/asm/pmu.h b/arch/mips/include/asm/pmu.h
> [...]
> > +
> > +#ifndef __MIPS_PMU_H__
> > +#define __MIPS_PMU_H__
> > +
> > +#if defined(CONFIG_CPU_MIPS32) || defined(CONFIG_CPU_MIPS64) || \
> > +    defined(CONFIG_CPU_R10000) || defined(CONFIG_CPU_SB1)
> [...]
> > +static int (*save_perf_irq)(void);
> 
> For we will use the save_perf_irq in the common function:
> mipspmu_get_irq() of the next patch, so, we need to move the definition
> of it out of the #if ... and put it before the #if:
> 
> ...
> +static int (*save_perf_irq)(void);
> 
> #if defined(CONFIG_CPU_MIPS32)
> ...

oh, no, For Oprofile not use it, we can define it before
mipspmu_get_irq() directly.

> 
> Regards,
>       Wu Zhangjin



<Prev in Thread] Current Thread [Next in Thread>