Re: [PATCH 10/12] add the sm501fb option to sm501 fb driver

[Arnaud Patard <apatard@mandriva.com>]

yajin <yajinzhou@vm-kernel.org> writes:

> Hi,
>
>>> Why not get this added to the main mode database instead of
>>> adding a new one into the sm501 driver?
>
>> fwiw, the original patch is putting it in the main database.
>
> According to the Documentation/fb/modedb.txt, that's because the
> modedb.c provides one generic video mode database with a fair amount
> of standard videomodes. Yes, 1024x600 can be added to maindb, but I am
> wondering whether it is a generic video mode. If so, there should be

afair it is fairly generic

> 1024x600 in main database already.

Not seeing a mode is the database doesn't mean it shouldn't go
there. It may only mean that nobody needed it before.

Arnaud