linux-mips
[Top] [All Lists]

Re: [PATCH 10/12] add the sm501fb option to sm501 fb driver

To: yajin <yajinzhou@vm-kernel.org>
Subject: Re: [PATCH 10/12] add the sm501fb option to sm501 fb driver
From: Arnaud Patard <apatard@mandriva.com>
Date: Wed, 05 May 2010 15:31:14 +0200
Cc: Ben Dooks <ben@simtec.co.uk>, linux-mips@linux-mips.org
In-reply-to: <o2u180e2c241005050617h299beefdm2fd046c94bdf3101@mail.gmail.com> (yajin's message of "Wed, 5 May 2010 21:17:29 +0800")
Organization: Mandriva
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <r2l180e2c241005040255mff483747jcef507aadea0cabd@mail.gmail.com> <4BE1614D.1090008@simtec.co.uk> <m3wrviv8a8.fsf@anduin.mandriva.com> <o2u180e2c241005050617h299beefdm2fd046c94bdf3101@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.1 (gnu/linux)
yajin <yajinzhou@vm-kernel.org> writes:

> Hi,
>
>>> Why not get this added to the main mode database instead of
>>> adding a new one into the sm501 driver?
>
>> fwiw, the original patch is putting it in the main database.
>
> According to the Documentation/fb/modedb.txt, that's because the
> modedb.c provides one generic video mode database with a fair amount
> of standard videomodes. Yes, 1024x600 can be added to maindb, but I am
> wondering whether it is a generic video mode. If so, there should be

afair it is fairly generic

> 1024x600 in main database already.

Not seeing a mode is the database doesn't mean it shouldn't go
there. It may only mean that nobody needed it before.

Arnaud

<Prev in Thread] Current Thread [Next in Thread>