linux-mips
[Top] [All Lists]

Re: [PATCH 10/12] add the sm501fb option to sm501 fb driver

To: Arnaud Patard <apatard@mandriva.com>
Subject: Re: [PATCH 10/12] add the sm501fb option to sm501 fb driver
From: yajin <yajinzhou@vm-kernel.org>
Date: Wed, 5 May 2010 21:17:29 +0800
Cc: Ben Dooks <ben@simtec.co.uk>, linux-mips@linux-mips.org
In-reply-to: <m3wrviv8a8.fsf@anduin.mandriva.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <r2l180e2c241005040255mff483747jcef507aadea0cabd@mail.gmail.com> <4BE1614D.1090008@simtec.co.uk> <m3wrviv8a8.fsf@anduin.mandriva.com>
Sender: linux-mips-bounce@linux-mips.org
Hi,

>> Why not get this added to the main mode database instead of
>> adding a new one into the sm501 driver?

> fwiw, the original patch is putting it in the main database.

According to the Documentation/fb/modedb.txt, that's because the
modedb.c provides one generic video mode database with a fair amount
of standard videomodes. Yes, 1024x600 can be added to maindb, but I am
wondering whether it is a generic video mode. If so, there should be
1024x600 in main database already.

yajin

http://vm-kernel.org



2010/5/5 Arnaud Patard <apatard@mandriva.com>:
> Ben Dooks <ben@simtec.co.uk> writes:
>
> Hi,
>
>> On 04/05/10 18:55, yajin wrote:
>>> Currently the sm501 mode can only be fetched from modedb.c.
>>> Unfortunately the modes in modedb.c are not complete. For example it
>>> lacks the resolution of 1024x600. So the sm501 fb driver should have
>>> the ability to accept the mode option from linux command line.
>>
>> Why not get this added to the main mode database instead of
>> adding a new one into the sm501 driver?
>
> fwiw, the original patch is putting it in the main database. Please
> wait that all this stuff is sorted out. Theses patches are based on the
> patches I'm working on and are adding some bugs in them.
>
> Arnaud
>

<Prev in Thread] Current Thread [Next in Thread>