linux-mips
[Top] [All Lists]

Re: [PATCH 8/12] gdium uses different freq of mclk&m1xclk of sm501

To: yajin <yajinzhou@vm-kernel.org>
Subject: Re: [PATCH 8/12] gdium uses different freq of mclk&m1xclk of sm501
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Tue, 04 May 2010 14:19:06 +0400
Cc: linux-mips@linux-mips.org, loongson-dev <loongson-dev@googlegroups.com>, wuzhangjin@gmail.com, apatard@mandriva.com, vince@simtec.co.uk, ben@simtec.co.uk
In-reply-to: <q2u180e2c241005040255n628614a0p828116a04f65a894@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <q2u180e2c241005040255n628614a0p828116a04f65a894@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.24 (Windows/20100228)
Hello.

yajin wrote:

Gdium uses different freq of mclk&m1xclk of sm501. This seems a dirty
hack. Maybe we need a configuration option for changing the freq of
these clocks.

Signed-off-by: yajin <yajin@vm-kernel.org>
---
 drivers/mfd/sm501.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index ce5dfce..5e55cbd 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1606,10 +1606,15 @@ static struct sm501_initdata sm501_pci_initdata = {
        .devices        = SM501_USE_ALL,

        /* Errata AB-3 says that 72MHz is the fastest available
-        * for 33MHZ PCI with proper bus-mastering operation */
-
+        * for 33MHZ PCI with proper bus-mastering operation
+        * For gdium, it works under 84&112M clock freq.*/

According to CodingStyle, style of multiline comments should preferably be:

/*
* bla
* bla
* bla
*/

WBR, Sergei


<Prev in Thread] Current Thread [Next in Thread>