linux-mips
[Top] [All Lists]

Re: [PATCH] loongson 2f: Add gpio/gpioilb support

To: Arnaud Patard <apatard@mandriva.com>
Subject: Re: [PATCH] loongson 2f: Add gpio/gpioilb support
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 29 Apr 2010 16:46:23 +0100
Cc: wuzhangjin@gmail.com, linux-mips@linux-mips.org
In-reply-to: <m3iq7awiqi.fsf@anduin.mandriva.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <m3sk6ewpep.fsf@anduin.mandriva.com> <1272543102.30655.138.camel@localhost> <m3iq7awiqi.fsf@anduin.mandriva.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Thu, Apr 29, 2010 at 02:23:01PM +0200, Arnaud Patard wrote:

> > The above blank line is at the end of the file, we can remove it,
> > otherwise, "git am" will complain about it.
> 
> Then, please, either fix your tool or fix it yourself. Last time I've
> looked at Documentation/SubmittingPatches, it was not
> mentionned. Moreover, checkpatch.pl is not complaining. If you really
> think, it's a must have, ask to fix checkpatch.pl first otherwise it's
> going to be missed again and again.

git-am will complain about it - with a not terribly helpful message that
does not mention the offending file.  I've configured git to strip
trailing whitespace and blank lines automatically.  In a patch series
this could lead to the problem where a subsequent patch fails to apply
because got modified.

>  arch/mips/Kconfig                        |    2      2 +     0 -     0 !
>  arch/mips/include/asm/mach-lemote/gpio.h |   33      33 +    0 -     0 !
>  arch/mips/loongson/common/Makefile           |    2  2 +     0 -     0 !
>  arch/mips/loongson/common/gpio.c             |  128  128 +   0 -     0 !
>  arch/mips/loongson/common/platform.c         |   25  25 +    0 -     0 !
>  5 files changed, 190 insertions(+)

Your diffstat doesn't match what's in the patch:

 arch/mips/Kconfig                          |    2 
 arch/mips/loongson/common/gpio.c           |  140 ++++++++++++++++++++++++++++
 arch/mips/loongson/common/Makefile         |    1 
 arch/mips/include/asm/mach-loongson/gpio.h |   35 +++++++
 4 files changed, 178 insertions(+), 0 deletions(-)

So what's wrong, diffstat or patch?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>