linux-mips
[Top] [All Lists]

Re: [PATCH] loongson 2f: Add gpio/gpioilb support

To: wuzhangjin@gmail.com
Subject: Re: [PATCH] loongson 2f: Add gpio/gpioilb support
From: Arnaud Patard <apatard@mandriva.com>
Date: Thu, 29 Apr 2010 14:23:01 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <1272543102.30655.138.camel@localhost> (Wu Zhangjin's message of "Thu, 29 Apr 2010 20:11:42 +0800")
Organization: Mandriva
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <m3sk6ewpep.fsf@anduin.mandriva.com> <1272543102.30655.138.camel@localhost>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.1 (gnu/linux)
Wu Zhangjin <wuzhangjin@gmail.com> writes:

> On Thu, 2010-04-29 at 11:58 +0200, Arnaud Patard wrote:
>> This patch is adding support for the 4 GPIO availables on the ST LS2F
>> cpus.
>> 
>> Signed-off-by: Arnaud Patard <apatard@mandriva.com>
>> ---
> [...]
>> Index: linux-2.6/arch/mips/loongson/common/gpio.c
> [...]
>> +
>> +static int __init ls2f_gpio_setup(void)
>> +{
>> +    return gpiochip_add(&ls2f_chip);
>> +}
>> +arch_initcall(ls2f_gpio_setup);
>> +
>
> The above blank line is at the end of the file, we can remove it,
> otherwise, "git am" will complain about it.

Then, please, either fix your tool or fix it yourself. Last time I've
looked at Documentation/SubmittingPatches, it was not
mentionned. Moreover, checkpatch.pl is not complaining. If you really
think, it's a must have, ask to fix checkpatch.pl first otherwise it's
going to be missed again and again.

Thanks,
Arnaud

<Prev in Thread] Current Thread [Next in Thread>