| To: | wuzhangjin@gmail.com |
|---|---|
| Subject: | Re: [PATCH] Loongson2: add a primary perf support (not applicable) |
| From: | Deng-Cheng Zhu <dengcheng.zhu@gmail.com> |
| Date: | Thu, 29 Apr 2010 18:24:32 +0800 |
| Cc: | loongson-dev <loongson-dev@googlegroups.com>, linux-mips@linux-mips.org, ralf@linux-mips.org, Zhang Le <r0bertz@gentoo.org>, yajin <yajinzhou@vm-kernel.org> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=eFmv7vlTv7r8aHuvn1l3Qj2cfeaAKM4+5N+OlxeymLw=; b=A50O7CNRiL5Xlo+9lhVhonpn7dqfAJNuQo6FAbX2kOduNBeK3tvc9s4BDBu996yJ51 TZPQmn76CQUJRqc6KoHhjZVmo1XF1IBzV4sw14ruaRzkBguhHl33iFCr97vZdDLLKYaL DL7lP1HTtzdoVT/4KSm7KEf7p68onQfp0CbS0= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=OD3+dFk67do1HLioL47/PeoKrszbHRBqVCxnNwGO2AZP9nMyHjbWGVfCM9sc9IABk1 B4KOm9TMPKrqPYbLTQRIfed9QLkbOQAL/uRTVREKr8AWn7mFpsym/V5Xyain0AXlJnMP 0OC7dcTnN44ee1/WI/iG23m3XFrT440SmK2WE= |
| In-reply-to: | <1272514212.24709.18.camel@localhost> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1272468077-12292-1-git-send-email-wuzhangjin@gmail.com> <o2h1b4d75291004282029m19d46c01hb44bab3893395bae@mail.gmail.com> <1272514212.24709.18.camel@localhost> |
| Sender: | linux-mips-bounce@linux-mips.org |
> BTW: After comparing this patch and your > arch/mips/kernel/perf_event_mipsxx.c, perhaps we can share more common > functions, such as hw_perf_event_destroy(), hw_perf_enable(), > hw_perf_disable() and handle_associated_event()... hw_perf_event_destroy(): OK, if reset_counters() will be also implemented in non-mipsxx. hw_perf_enable()/hw_perf_disable(): OK. Initially I thought there could be different implementations for these 2 functions in non-mipsxx depending on the very different perf control regs and the use of saved_ctrl. But you are right, we can, and had better to move these up. handle_associated_event(): OK. Thanks! I'll apply these in v3. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] loongson 2f: Add gpio/gpioilb support, Arnaud Patard |
|---|---|
| Next by Date: | Re: [PATCH] arch/mips/loongson/common/machtype.c: Fix typo, Wu Zhangjin |
| Previous by Thread: | Re: [PATCH] Loongson2: add a primary perf support (not applicable), Wu Zhangjin |
| Next by Thread: | [PATCH 0/3] Check for accesses beyond end of PGD, David Daney |
| Indexes: | [Date] [Thread] [Top] [All Lists] |