linux-mips
[Top] [All Lists]

Re: [PATCH] die() does not call die notifier chain

To: Yury Polyanskiy <ypolyans@princeton.edu>
Subject: Re: [PATCH] die() does not call die notifier chain
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 28 Apr 2010 19:31:43 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20100426005310.0786273f@penta.localdomain>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20100426005310.0786273f@penta.localdomain>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Mon, Apr 26, 2010 at 12:53:10AM -0400, Yury Polyanskiy wrote:

Yuri,

> I think that the arch/mips implementation of die() forgets to call the
> notify_die() and thus notifiers registered via register_die_notifier()
> are not called.
> 
> For example this results in kgdb not being activated on exceptions.
> 
> The patch is very simple and attached: the only subtlety is that main
> notify_die declares regs argument w/o const, so I needed to remove const 
> from mips die() as well.

I'd have prefered to make all users of the reg pointer const in the hope
gcc can use that for optimization and to avoid stupid assignments via that
pointer but that turns out a significant problem on its own so I'm applying
your patch as is.

Please include a Signed-off-by: line (see Documentation/SubmittingPatches)
in future patches.  If your patch was any more complex than this I'd not
have considered it without one.

Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>