linux-mips
[Top] [All Lists]

Re: [RFC] net/sb1250: setup the pdevice within the soc code

To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Subject: Re: [RFC] net/sb1250: setup the pdevice within the soc code
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 26 Apr 2010 21:24:59 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20100426195229.GB22245@Chamillionaire.breakpoint.cc>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20100426195229.GB22245@Chamillionaire.breakpoint.cc>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Mon, Apr 26, 2010 at 09:52:29PM +0200, Sebastian Andrzej Siewior wrote:

> doing it within the driver does not look good.
> 
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> ---
> Ralf, if you fine with then I'm gonna to post it at netdev.
> 
>  arch/mips/sibyte/sb1250/setup.c |   55 ++++++++++++++++++
>  drivers/net/sb1250-mac.c        |  120 
> +--------------------------------------

Almost.  The idea is right but the driver is also being used by the
BCM1480-based platforms.  So either arch/mips/sibyte/bcm1480/setup.c
needs the same changes or - and better - you change
arch/mips/sibyte/swarm/platform.c instead.  Despite the swarm in the
path name that file is being used also for all other currently supported
Sibyte platforms.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>