linux-mips
[Top] [All Lists]

Re: [ltt-dev] [PATCH 1/3] lttng: MIPS: Fix syscall entry tracing.

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [ltt-dev] [PATCH 1/3] lttng: MIPS: Fix syscall entry tracing.
From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Date: Tue, 20 Apr 2010 09:55:48 -0400
Cc: ltt-dev@lists.casi.polymtl.ca, linux-mips@linux-mips.org
In-reply-to: <1271722791-27885-2-git-send-email-ddaney@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1271722791-27885-1-git-send-email-ddaney@caviumnetworks.com> <1271722791-27885-2-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
* David Daney (ddaney@caviumnetworks.com) wrote:
> For the 32-bit kernel and all three ABIs of the 64-bit kernel, we need
> to test the _TIF_KERNEL_TRACE flag on syscall entry.  Otherwise, no
> syscall entry tracing for you!

Merged into the LTTng tree, thanks !

Mathieu

> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> ---
>  arch/mips/kernel/scall32-o32.S |    2 +-
>  arch/mips/kernel/scall64-64.S  |    2 +-
>  arch/mips/kernel/scall64-n32.S |    2 +-
>  arch/mips/kernel/scall64-o32.S |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/mips/kernel/scall32-o32.S b/arch/mips/kernel/scall32-o32.S
> index fd2a9bb..28f262d 100644
> --- a/arch/mips/kernel/scall32-o32.S
> +++ b/arch/mips/kernel/scall32-o32.S
> @@ -52,7 +52,7 @@ NESTED(handle_sys, PT_SIZE, sp)
>  
>  stack_done:
>       lw      t0, TI_FLAGS($28)       # syscall tracing enabled?
> -     li      t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT
> +     li      t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT | _TIF_KERNEL_TRACE
>       and     t0, t1
>       bnez    t0, syscall_trace_entry # -> yes
>  
> diff --git a/arch/mips/kernel/scall64-64.S b/arch/mips/kernel/scall64-64.S
> index 18bf7f3..38c0c95 100644
> --- a/arch/mips/kernel/scall64-64.S
> +++ b/arch/mips/kernel/scall64-64.S
> @@ -54,7 +54,7 @@ NESTED(handle_sys64, PT_SIZE, sp)
>  
>       sd      a3, PT_R26(sp)          # save a3 for syscall restarting
>  
> -     li      t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT
> +     li      t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT | _TIF_KERNEL_TRACE
>       LONG_L  t0, TI_FLAGS($28)       # syscall tracing enabled?
>       and     t0, t1, t0
>       bnez    t0, syscall_trace_entry
> diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
> index 3541fd3..fbecc01 100644
> --- a/arch/mips/kernel/scall64-n32.S
> +++ b/arch/mips/kernel/scall64-n32.S
> @@ -53,7 +53,7 @@ NESTED(handle_sysn32, PT_SIZE, sp)
>  
>       sd      a3, PT_R26(sp)          # save a3 for syscall restarting
>  
> -     li      t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT
> +     li      t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT | _TIF_KERNEL_TRACE
>       LONG_L  t0, TI_FLAGS($28)       # syscall tracing enabled?
>       and     t0, t1, t0
>       bnez    t0, n32_syscall_trace_entry
> diff --git a/arch/mips/kernel/scall64-o32.S b/arch/mips/kernel/scall64-o32.S
> index 14dde4c..0db5589 100644
> --- a/arch/mips/kernel/scall64-o32.S
> +++ b/arch/mips/kernel/scall64-o32.S
> @@ -81,7 +81,7 @@ NESTED(handle_sys, PT_SIZE, sp)
>       PTR     4b, bad_stack
>       .previous
>  
> -     li      t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT
> +     li      t1, _TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT | _TIF_KERNEL_TRACE
>       LONG_L  t0, TI_FLAGS($28)       # syscall tracing enabled?
>       and     t0, t1, t0
>       bnez    t0, trace_a_syscall
> -- 
> 1.6.6.1
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev@lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com

<Prev in Thread] Current Thread [Next in Thread>