linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Alchemy: db1200: remove custom wait implementation

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH] MIPS: Alchemy: db1200: remove custom wait implementation
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 7 Apr 2010 16:34:56 +0100
Cc: Linux-MIPS <linux-mips@linux-mips.org>, Manuel Lauss <manuel.lauss@gmail.com>
In-reply-to: <1270307223-3825-1-git-send-email-manuel.lauss@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1270307223-3825-1-git-send-email-manuel.lauss@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Sat, Apr 03, 2010 at 05:07:03PM +0200, Manuel Lauss wrote:

> While playing with the out-of-tree MAE driver module, the system
> would panic after a while in the db1200 custom wait code after
> wakeup due to a clobbered k0 register being used as target address
> of a store op.
> 
> Remove the custom wait implementation and revert back to the
> Alchemy-recommended implementation already set as default.
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> I've played a few hours worth of video from a SD card now without
> a hitch; usually the panic would occur after ~10 minutes.
> 
> Please add this to the 2.6.34 queue, Thanks!

Yes, this use of k0 was definately looking fishy - and I'm not talking
about the kind of fish in a bouillabaisse ;-)

Applied.  Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>