linux-mips
[Top] [All Lists]

Re: [PATCH 0/2] Fix ethernet driver for Octeon based Movidis hard

To: David Miller <davem@davemloft.net>
Subject: Re: [PATCH 0/2] Fix ethernet driver for Octeon based Movidis hardware
From: Greg KH <gregkh@suse.de>
Date: Fri, 2 Apr 2010 10:04:24 -0700
Cc: ddaney@caviumnetworks.com, ralf@linux-mips.org, linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <20100401.182045.106908204.davem@davemloft.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1270171075-12741-1-git-send-email-ddaney@caviumnetworks.com> <20100401.182045.106908204.davem@davemloft.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Apr 01, 2010 at 06:20:45PM -0700, David Miller wrote:
> From: David Daney <ddaney@caviumnetworks.com>
> Date: Thu,  1 Apr 2010 18:17:53 -0700
> 
> > The Movidis X16 bootloader doesn't enable the mdio bus.  The first
> > patch fixes this by enabling the mdio bus when the driver is
> > initialized.
> > 
> > Also the addresses of the PHYs was unknown for this device.  The
> > second patch adds the corresponding PHY addresses.
> > 
> > With both patches applied I can successfully use all eight Ethernet
> > ports.
> > 
> > Please consider for 2.6.34.  Since Octeon is an embedded MIPS SOC it
> > is unlikely to break the kernel for any workstations.  Any or all of
> > these could be considered for merging via Ralf's linux-mips.org tree.
> 
> Ralf please merge this via your MIPS tree, thanks:
> 
> Acked-by: David S. Miller <davem@davemloft.net>

I agree, Ralf, please take these and you can add:
        Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
to them.

thanks,

greg k-h

<Prev in Thread] Current Thread [Next in Thread>