linux-mips
[Top] [All Lists]

Re: [PATCH v3 2/3] Loongson-2F: Enable fixups of binutils 2.20.1

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH v3 2/3] Loongson-2F: Enable fixups of binutils 2.20.1
From: Zhang Le <r0bertz@gentoo.org>
Date: Sat, 27 Mar 2010 16:29:00 +0000
Cc: Wu Zhangjin <wuzhangjin@gmail.com>, linux-mips@linux-mips.org, Shinya Kuribayashi <shinya.kuribayashi@necel.com>, Wu Zhangjin <wuzj@lemote.com>, fxzhang@lemote.com
In-reply-to: <20100317135223.GA4554@linux-mips.org>
Mail-followup-to: Ralf Baechle <ralf@linux-mips.org>, Wu Zhangjin <wuzhangjin@gmail.com>, linux-mips@linux-mips.org, Shinya Kuribayashi <shinya.kuribayashi@necel.com>, Wu Zhangjin <wuzj@lemote.com>, fxzhang@lemote.com
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1268453720.git.wuzhangjin@gmail.com> <ecc51ee134ab84c95b6b02534544df3731bb9562.1268453720.git.wuzhangjin@gmail.com> <20100317135223.GA4554@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.16 (2007-06-09)
On 14:52 Wed 17 Mar     , Ralf Baechle wrote:
> On Sat, Mar 13, 2010 at 12:34:16PM +0800, Wu Zhangjin wrote:
> 
> > diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> > index 2f2eac2..5ae342e 100644
> > --- a/arch/mips/Makefile
> > +++ b/arch/mips/Makefile
> > @@ -135,7 +135,9 @@ cflags-$(CONFIG_CPU_LOONGSON2)  += -Wa,--trap
> >  cflags-$(CONFIG_CPU_LOONGSON2E) += \
> >     $(call cc-option,-march=loongson2e,-march=r4600)
> >  cflags-$(CONFIG_CPU_LOONGSON2F) += \
> > -   $(call cc-option,-march=loongson2f,-march=r4600)
> > +   $(call cc-option,-march=loongson2f,-march=r4600) \
> > +   $(call as-option,-Wa$(comma)-mfix-loongson2f-nop,) \
> > +   $(call as-option,-Wa$(comma)-mfix-loongson2f-jump,)
> 
> Shouldn't these options be used unconditionally?  It seems a kernel build
> should rather fail than a possibly unreliable kernel be built - possibly
> even without the user noticing the problem.

Zhangjin has been busy preparing for his graduation paper.
I just talked to him. He said later batches of 2F processor is not affected by
these two problems, according to Zhang Fuxin, manager of Lemote.

I am not sure on which model of Fuloong and Yeeloong these "good" 2F processors
have been used. I think Fuxin should know this.

If Fuxin could told us now, we can make a new patch. In this patch, we decide
whether to add these options or not base on the model number.

Otherwise, for now, I think we should enable these options unconditionally.

Zhang, Le

<Prev in Thread] Current Thread [Next in Thread>