linux-mips
[Top] [All Lists]

Re: [PATCH v3 2/3] Loongson-2F: Enable fixups of binutils 2.20.1

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH v3 2/3] Loongson-2F: Enable fixups of binutils 2.20.1
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 17 Mar 2010 14:52:23 +0100
Cc: linux-mips@linux-mips.org, Shinya Kuribayashi <shinya.kuribayashi@necel.com>, Zhang Le <r0bertz@gentoo.org>, Wu Zhangjin <wuzj@lemote.com>
In-reply-to: <ecc51ee134ab84c95b6b02534544df3731bb9562.1268453720.git.wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1268453720.git.wuzhangjin@gmail.com> <ecc51ee134ab84c95b6b02534544df3731bb9562.1268453720.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Sat, Mar 13, 2010 at 12:34:16PM +0800, Wu Zhangjin wrote:

> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 2f2eac2..5ae342e 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -135,7 +135,9 @@ cflags-$(CONFIG_CPU_LOONGSON2)    += -Wa,--trap
>  cflags-$(CONFIG_CPU_LOONGSON2E) += \
>       $(call cc-option,-march=loongson2e,-march=r4600)
>  cflags-$(CONFIG_CPU_LOONGSON2F) += \
> -     $(call cc-option,-march=loongson2f,-march=r4600)
> +     $(call cc-option,-march=loongson2f,-march=r4600) \
> +     $(call as-option,-Wa$(comma)-mfix-loongson2f-nop,) \
> +     $(call as-option,-Wa$(comma)-mfix-loongson2f-jump,)

Shouldn't these options be used unconditionally?  It seems a kernel build
should rather fail than a possibly unreliable kernel be built - possibly
even without the user noticing the problem.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>