linux-mips
[Top] [All Lists]

Re: [PATCH] mips: Fix SSB PCIcore IO resource management

To: Andreas Ferber <af@chaos-agency.de>
Subject: Re: [PATCH] mips: Fix SSB PCIcore IO resource management
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 16 Mar 2010 18:33:59 +0100
Cc: Markus Wigge <markus@cultcom.de>, Michael Buesch <mb@bu3sch.de>, linux-mips@linux-mips.org
In-reply-to: <20100316113551.GB19241@marcant.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20100316113551.GB19241@marcant.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Tue, Mar 16, 2010 at 12:35:51PM +0100, Andreas Ferber wrote:

> The SSB PCIcore code reused the IO resource fixup code from the original
> 2.4.x Broadcom patch for BCM47xx based devices, which was a quick hack
> for doing PCI IO resource configuration back then (the boot loader
> doesn't configure PCI devices on this platform).
> 
> However, this code is no longer necessary since the kernel now can do
> PCI resource management fine all by itself, so remove the old code.
> 
> When removing the code, it becomes obvious that the mem_offset setting
> in the PCIcore driver was wrong, however this was masked by the fixup
> code before, except in a few cases involving yenta_socket. For
> BCM47xx, the correct offset is 0, and since this is the only device
> using PCIcore in host mode, the offset can simply be removed
> unconditionally.

Thanks, applied.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>