[Top] [All Lists]

Re: [PATCH] init dynamic bin_attribute structures

To: Jiri Kosina <>
Subject: Re: [PATCH] init dynamic bin_attribute structures
From: Linus Torvalds <>
Date: Mon, 15 Mar 2010 11:47:53 -0700 (PDT)
Cc: Wolfram Sang <>,, Grant Likely <>,, "Eric W. Biederman" <>, Ralf Baechle <>, Paul Gortmaker <>, Alessandro Zummo <>,,
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)

On Mon, 15 Mar 2010, Jiri Kosina wrote:
> I don't understand how cocinelle works, but the resulting patch seems to 
> be incomplete.
> The fix is needed at least in firmware loader (for which Greg has already 
> queued patch), in ACPI thermal driver [1], etc).

The firmware loader should be done differently:

and I suspect that Wolfram may have skipped the thermal one as having been 
done by another patch (that I didn't merge, due to having questions about 
the whole issue, but that I don't have any objections to)

But maybe there is also some limitation to the coccinelle rule too.


<Prev in Thread] Current Thread [Next in Thread>