linux-mips
[Top] [All Lists]

[PATCH v3 3/3] Loongson-2F: Fixup of problems introduced by -mfix-loongs

To: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH v3 3/3] Loongson-2F: Fixup of problems introduced by -mfix-loongson2f-jump of binutils 2.20.1
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Sat, 13 Mar 2010 12:34:17 +0800
Cc: linux-mips@linux-mips.org, Shinya Kuribayashi <shinya.kuribayashi@necel.com>, Wu Zhangjin <wuzhangjin@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references:in-reply-to:references; bh=zr893OWQ3vUwhyg6oJp4MD6FThtWm5mK31cbV664TB8=; b=x/ePD0JpPJZNB+qSQ7ZvlGKy0liJBS9L+7A2lv43Rg6mW7nSP8+NdwxcCIuglFQQVJ rL94QR1y+rfUgQB1xf+6l/QaTMTT1R14V/0wq2QNDVOf16uy6IqV0sVilRp6SHDJHko0 tAA36xt1OZg6xxtR/h600fU4NAf07vuqTNIhU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=hpgOHkTAMVe7UWU4ZtP58dZI2aLOAs0TYoHtfqcbhwF85FhXgVNgMXPNeFWHERj8ki gsGwhBkRC8bUmdzKRhelKReINo210R126jLfDW9oLZEI/c36fcDe/eAFHBOOSoVsbKYe cs6dLzRhQOZL5CjaES+mA4pb4cNTHpD6pVut4=
In-reply-to: <cover.1268453720.git.wuzhangjin@gmail.com>
In-reply-to: <cover.1268453720.git.wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1268453720.git.wuzhangjin@gmail.com>
References: <cover.1268453720.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
From: Wu Zhangjin <wuzhangjin@gmail.com>

The -mfix-loongson2f-jump option provided by the binutils 2.20.1 have fixed the
Out-of-order Issue of Loongson-2F described in Chapter 15 of "Loongson2F User
Manual"[1,2], but introduced some problems.

The option changes all of the jumping target to "addr & 0xcfffffff" through the
at($1) register, but for the REBOOT address of loongson-2F: 0xbfc00000, this is
totally wrong, so, this patch try to avoid the problem via telling the
assembler not to use at($1) register.

[1] Loongson2F User Manual(Chinese Version)
http://www.loongson.cn/uploadfile/file/200808211
[2] English Version of Chapter 15:
http://groups.google.com.hk/group/loongson-dev/msg/e0d2e220958f10a6?dmode=source

Reported-and-tested-by: Liu Shiwei <liushiwei@gmail.com>
Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
---
 arch/mips/loongson/common/reset.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/arch/mips/loongson/common/reset.c 
b/arch/mips/loongson/common/reset.c
index 4bd9c18..dc311f2 100644
--- a/arch/mips/loongson/common/reset.c
+++ b/arch/mips/loongson/common/reset.c
@@ -21,8 +21,17 @@ static void loongson_restart(char *command)
        /* do preparation for reboot */
        mach_prepare_reboot();
 
-       /* reboot via jumping to boot base address */
+       /* reboot via jumping to boot base address
+        *
+        * ".set noat" and ".set at" are used to ensure the address not break
+        * by the -mfix-loongson2f-jump option provided by binutils 2.20.1 (or
+        * higher version) which try to change the jumping address to "addr &
+        * 0xcfffffff" via the at($1) register, this is totally wrong for
+        * 0xbfc00000 (LOONGSON_BOOT_BASE).
+        */
+       __asm__ __volatile__(".set noat\n");
        ((void (*)(void))ioremap_nocache(LOONGSON_BOOT_BASE, 4)) ();
+       __asm__ __volatile__(".set at\n");
 }
 
 static void loongson_poweroff(void)
-- 
1.7.0.1


<Prev in Thread] Current Thread [Next in Thread>