linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: tracing: Optimize the implementation

To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] MIPS: tracing: Optimize the implementation
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Fri, 12 Mar 2010 18:11:35 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, Steven Rostedt <srostedt@redhat.com>, linux-mips@linux-mips.org, David Daney <ddaney@caviumnetworks.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=mZbQYMLk+4voatF7uYgQaESzSIAXzmsGpjZV3V0Z8Is=; b=iDfjp/hJxWH+uxwWh6GMSPCC0XfJPh1Kl3O9T5P4VCnAR52YGtUpKHH+wWkqs/4QuM l/z4hrCekVRzJptDjhO4JpteNaGxF68snsC9XG6ACs4On6MlEy19Si2GZTN0NsAs+6ew Rhzd8cuK0MgxhNK1P/jSmV3bTwZ+gCb0NUHTA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=B7sJ2AyJ1Da2YPGqia2vHt2JcolkzzUMN5iLzhVSHpKNpvtPnDu8oLL8wlOb14BJtk ZmpbymzaIyU/0YoT3Ze0czfbP1kCNytuI6vVqGXlJoX4mVmYNk3BdTme03JGb7m2yVZy QQeIcBySq94Lh5ZDEVeEReHuoG4UJSgGeTXeU=
In-reply-to: <20100312085053.GB6364@alpha.franken.de>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <8b93c417fefa4d446f801abfd718ba94fdcb1821.1268330348.git.wuzhangjin@gmail.com> <20100312085053.GB6364@alpha.franken.de>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Fri, 2010-03-12 at 09:50 +0100, Thomas Bogendoerfer wrote:
> On Fri, Mar 12, 2010 at 02:07:37AM +0800, Wu Zhangjin wrote:
> > +/*
> > + * If the Instruction Pointer is in module space (0xc0000000), return ture;
> > + * otherwise, it is in kernel space (0x80000000), return false.
> > + */
> > +#define in_module(ip) (unlikely((ip) & 0x40000000))
> > +
> 
> looks broken for 64bit, but maybe this is a 32bit only feature...

Actually, this works well on my 64bit YeeLoong laptop ;)

But we should find another better solution.

Regards,
        Wu Zhangjin



<Prev in Thread] Current Thread [Next in Thread>