| To: | Wu Zhangjin <wuzhangjin@gmail.com> |
|---|---|
| Subject: | Re: [PATCH] MIPS: tracing: Optimize the implementation |
| From: | Thomas Bogendoerfer <tsbogend@alpha.franken.de> |
| Date: | Fri, 12 Mar 2010 09:50:53 +0100 |
| Cc: | Ralf Baechle <ralf@linux-mips.org>, Steven Rostedt <srostedt@redhat.com>, linux-mips@linux-mips.org, David Daney <ddaney@caviumnetworks.com> |
| In-reply-to: | <8b93c417fefa4d446f801abfd718ba94fdcb1821.1268330348.git.wuzhangjin@gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <8b93c417fefa4d446f801abfd718ba94fdcb1821.1268330348.git.wuzhangjin@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, Mar 12, 2010 at 02:07:37AM +0800, Wu Zhangjin wrote: > +/* > + * If the Instruction Pointer is in module space (0xc0000000), return ture; > + * otherwise, it is in kernel space (0x80000000), return false. > + */ > +#define in_module(ip) (unlikely((ip) & 0x40000000)) > + looks broken for 64bit, but maybe this is a 32bit only feature... Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary a good idea. [ RFC1925, 2.3 ] |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/3] arch/mips/txx9/generic: init dynamic bin_attribute structures, Wolfram Sang |
|---|---|
| Next by Date: | Re: [PATCH] MIPS: tracing: Optimize the implementation, Ralf Baechle |
| Previous by Thread: | [PATCH] MIPS: tracing: Optimize the implementation, Wu Zhangjin |
| Next by Thread: | Re: [PATCH] MIPS: tracing: Optimize the implementation, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |