linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c
From: Yang Shi <yang.shi@windriver.com>
Date: Thu, 11 Mar 2010 10:53:44 +0800
Cc: ddaney@caviumnetworks.com, linux-mips@linux-mips.org
In-reply-to: <20100309191750.GA1960@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1268115862-25976-1-git-send-email-yang.shi@windriver.com> <20100309190309.GA301@linux-mips.org> <20100309191750.GA1960@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.23 (X11/20090817)
Ralf Baechle 写道:
On Tue, Mar 09, 2010 at 08:03:09PM +0100, Ralf Baechle wrote:

@@ -281,7 +281,7 @@ static void octeon_cpu_die(unsigned int cpu)
#ifdef CONFIG_CAVIUM_OCTEON_WATCHDOG
        /* Disable the watchdog */
-       cvmx_ciu_wdogx_t ciu_wdog;
+       union cvmx_ciu_wdogx ciu_wdog;
        ciu_wdog.u64 = cvmx_read_csr(CVMX_CIU_WDOGX(cpu));
        ciu_wdog.s.mode = 0;
        cvmx_write_csr(CVMX_CIU_WDOGX(cpu), ciu_wdog.u64);
David,

I think this ifdef should be replaced by a notifier called from
__cpu_die().

Since this is unused I'll just remove it for now.

This breaks kernel build when HOTPLUG_CPU is enabled.

Regards,
Yang

  Ralf



<Prev in Thread] Current Thread [Next in Thread>