linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Alchemy: move MMC driver registration to board code.

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH] MIPS: Alchemy: move MMC driver registration to board code.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 10 Mar 2010 17:48:24 +0100
Cc: Sergei Shtylyov <sshtylyov@mvista.com>, Linux-MIPS <linux-mips@linux-mips.org>, Manuel Lauss <manuel.lauss@gmail.com>
In-reply-to: <f861ec6f1003090403j190d0ddbp7e245d0990a62a51@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1268076181-29642-1-git-send-email-manuel.lauss@gmail.com> <1268076181-29642-3-git-send-email-manuel.lauss@gmail.com> <4B963210.7030906@ru.mvista.com> <f861ec6f1003090345n53570102je68aef14e8b3f3fb@mail.gmail.com> <4B96364E.5050202@mvista.com> <f861ec6f1003090403j190d0ddbp7e245d0990a62a51@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Tue, Mar 09, 2010 at 01:03:51PM +0100, Manuel Lauss wrote:

> And on a personal note, that file just bothers me.  It's messy, can
> cause merge conflicts,

Eye cancer.

> it references structures defined inside board-specific code. In short,
> it just plain annoys
> my sense of aesthetics.

Indeed - and I don't think Sergej disagrees with that.  I agree with him
that device registration code should primarily be done in the SOC code -
but you'll need to somehow get that code to communicate with the platform
code about what really needs to be done then register the remainder of
the truely platform-specific platform devices.  Something like that.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>