linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] Loongson-2F: Flush the branch target history such as BTB

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 1/3] Loongson-2F: Flush the branch target history such as BTB and RAS
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Wed, 10 Mar 2010 23:24:04 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, Greg KH <gregkh@suse.de>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=SQ+lGJkXfLsBokfGNBa8HG9EaBvcmeC0REL3zP7AGOo=; b=ieqvcBhObZwTt8k5tQmeQ5H2s2/U8Hm50YZOGVB1jf8t28Vis3wra9c4CBYtpnXR1G Pq0OkeEOpiPSAYrA+ILbaNZw8aJI9lvzDtJOT6z7i3nh0DtKsE7zPHQUSUW289GCWu7H hOBR9ZN6mEN1U3RGg3hdXjc+v1jQs7ZcqXtdc=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=Em+J66uA+sEgOKw0BIOxRK+riWl+r0CR3tm1ooXjzinzJbFQqwLEjs/U4zTEuXLeXy DcJUcYjTP9xLu1Hwz/3wiySfvsTovVE68PZrWY0vDl6hMG2UYMB/daa1AYlqYqWPAnfd qGwUPFK8Qzol+wQQjSf3AGce9YLXeAv/5RP0E=
In-reply-to: <4B977815.4000703@ru.mvista.com>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1268153722.git.wuzhangjin@gmail.com> <d513f16856e499e82f0b4e428c97fe06afb5a426.1268153722.git.wuzhangjin@gmail.com> <4B977815.4000703@ru.mvista.com>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
Hi,

Thanks very much for your careful review, will resend a new one later.

Regards,
        Wu Zhangjin

On Wed, 2010-03-10 at 13:44 +0300, Sergei Shtylyov wrote:
[...]
> > diff --git a/arch/mips/include/asm/stackframe.h 
> > b/arch/mips/include/asm/stackframe.h
> > index 3b6da33..b84cfda 100644
> > --- a/arch/mips/include/asm/stackframe.h
> > +++ b/arch/mips/include/asm/stackframe.h
> > @@ -121,6 +121,25 @@
> >             .endm
> >  #else
> >             .macro  get_saved_sp    /* Uniprocessor variation */
> > +#ifdef CONFIG_CPU_LOONGSON2F
> > +           /*
> > +            * Clear BTB(branch target buffer), forbid RAS(row address
> > +            * strobe)
> 
>    No spaces before the left paren...
> 
> >  to workaround the Out-of-oder Issue in Loongson2F
> > +            * via it's diagnostic register.
> >   
> 
>    Only "its".
> 
> > +            */
> > +           move k0, ra
> >   
> 
>    Operands misalined...
> 
> WBR, Sergei
> 
> 



<Prev in Thread] Current Thread [Next in Thread>