linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c

To: Yang Shi <yang.shi@windriver.com>
Subject: Re: [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 9 Mar 2010 20:17:50 +0100
Cc: ddaney@caviumnetworks.com, linux-mips@linux-mips.org
In-reply-to: <20100309190309.GA301@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1268115862-25976-1-git-send-email-yang.shi@windriver.com> <20100309190309.GA301@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Tue, Mar 09, 2010 at 08:03:09PM +0100, Ralf Baechle wrote:

> > @@ -281,7 +281,7 @@ static void octeon_cpu_die(unsigned int cpu)
> >  
> >  #ifdef CONFIG_CAVIUM_OCTEON_WATCHDOG
> >     /* Disable the watchdog */
> > -   cvmx_ciu_wdogx_t ciu_wdog;
> > +   union cvmx_ciu_wdogx ciu_wdog;
> >     ciu_wdog.u64 = cvmx_read_csr(CVMX_CIU_WDOGX(cpu));
> >     ciu_wdog.s.mode = 0;
> >     cvmx_write_csr(CVMX_CIU_WDOGX(cpu), ciu_wdog.u64);
> 
> David,
> 
> I think this ifdef should be replaced by a notifier called from
> __cpu_die().

Since this is unused I'll just remove it for now.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>