linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c

To: Yang Shi <yang.shi@windriver.com>
Subject: Re: [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 9 Mar 2010 20:03:09 +0100
Cc: ddaney@caviumnetworks.com, linux-mips@linux-mips.org
In-reply-to: <1268115862-25976-1-git-send-email-yang.shi@windriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1268115862-25976-1-git-send-email-yang.shi@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Tue, Mar 09, 2010 at 02:24:22PM +0800, Yang Shi wrote:

> Change cvmx_ciu_wdogx_t type to "union cvmx_ciu_wdogx".
> 
> Signed-off-by: Yang Shi <yang.shi@windriver.com>
> ---
>  arch/mips/cavium-octeon/smp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
> index 51e9802..52d61ba 100644
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -281,7 +281,7 @@ static void octeon_cpu_die(unsigned int cpu)
>  
>  #ifdef CONFIG_CAVIUM_OCTEON_WATCHDOG
>       /* Disable the watchdog */
> -     cvmx_ciu_wdogx_t ciu_wdog;
> +     union cvmx_ciu_wdogx ciu_wdog;
>       ciu_wdog.u64 = cvmx_read_csr(CVMX_CIU_WDOGX(cpu));
>       ciu_wdog.s.mode = 0;
>       cvmx_write_csr(CVMX_CIU_WDOGX(cpu), ciu_wdog.u64);

David,

I think this ifdef should be replaced by a notifier called from
__cpu_die().

  Ralf

<Prev in Thread] Current Thread [Next in Thread>