linux-mips
[Top] [All Lists]

Re: [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 9 Mar 2010 15:16:06 +0100
Cc: Yang Shi <yang.shi@windriver.com>, f.fainelli@gmail.com, linux-mips@linux-mips.org
In-reply-to: <4B8EA94B.1020203@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1267605801-5305-1-git-send-email-yang.shi@windriver.com> <fd8fb199609e60a5b6c10e2073976a3f6b599109.1267604875.git.yang.shi@windriver.com> <50e36e8549769a26986f99a23772d23fd039c230.1267604875.git.yang.shi@windriver.com> <004eb64c73b3bcec90612663598ada4cf678f236.1267604875.git.yang.shi@windriver.com> <4B8EA94B.1020203@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Wed, Mar 03, 2010 at 10:24:11AM -0800, David Daney wrote:

> On 03/03/2010 12:43 AM, Yang Shi wrote:
> >Octeon's setup.c uses add_wired_entry, but it is not declared
> >anywhere. Copy add_wired_entry decralation from pgtable-32.h to
> >pgtable-64.h and include asm/pgtable.h into Octeon's setup.c.
> >
> >Signed-off-by: Yang Shi<yang.shi@windriver.com>
> 
> NAK!
> 
> We are removing the use of add_wired_entry(), so adding a
> declaration will not be necessary.

For explanation - add_wired_entry is a horrible API; it requires the user
to have knowledge about the TLB structure, code differently for 32-bit and
64-bit kernels.  It's just the API of terror.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>